You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by "SingingBush (via GitHub)" <gi...@apache.org> on 2024/09/24 00:52:42 UTC
[PR] set Automatic-Module-Name for xercesImpl.jar [xerces-j]
SingingBush opened a new pull request, #3:
URL: https://github.com/apache/xerces-j/pull/3
Ideally xerces should fully support JPMS but whilst it's still targeting JDK 8 perhaps it's worth defining an Automatic-Module-Name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] [XERCESJ-1763] set Automatic-Module-Name for xercesImpl.jar [xerces-j]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #3:
URL: https://github.com/apache/xerces-j/pull/3#discussion_r2174694451
##########
build.xml:
##########
@@ -351,6 +351,7 @@ Authors:
org/w3c/dom/html/HTMLDOMImplementation.class"
manifest="${build.dir}/manifest.xerces">
<manifest>
+ <attribute name="Automatic-Module-Name" value="org.apache.xerces.impl"/>
Review Comment:
we need to think about this more. How many jars does Xerces publish and which ones? Is there a split package problem to deal with?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] [XERCESJ-1763] set Automatic-Module-Name for xercesImpl.jar [xerces-j]
Posted by "SingingBush (via GitHub)" <gi...@apache.org>.
SingingBush commented on code in PR #3:
URL: https://github.com/apache/xerces-j/pull/3#discussion_r2173831754
##########
build.xml:
##########
@@ -351,6 +351,7 @@ Authors:
org/w3c/dom/html/HTMLDOMImplementation.class"
manifest="${build.dir}/manifest.xerces">
<manifest>
+ <attribute name="Automatic-Module-Name" value="org.apache.xerces.impl"/>
Review Comment:
I went with that because the jar is named xercesImpl.jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] [XERCESJ-1763] set Automatic-Module-Name for xercesImpl.jar [xerces-j]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #3:
URL: https://github.com/apache/xerces-j/pull/3#discussion_r2174704367
##########
build.xml:
##########
@@ -351,6 +351,7 @@ Authors:
org/w3c/dom/html/HTMLDOMImplementation.class"
manifest="${build.dir}/manifest.xerces">
<manifest>
+ <attribute name="Automatic-Module-Name" value="org.apache.xerces.impl"/>
Review Comment:
Looking at Maven Central I think the only current jar is xerces:xercesImpl:
https://search.maven.org/search?q=g:xerces
In that case, I think org.apache.xerces.
However, if there's some sort of legacy issue here where the module name is already xercesImpl and people depend on that, we should stick to that. I don't think org.apache.xerces.impl is a good option though. "impl" generally implies something that should be hidden from clients
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] XERCESJ-1763: set Automatic-Module-Name for xercesImpl.jar [xerces-j]
Posted by "SingingBush (via GitHub)" <gi...@apache.org>.
SingingBush commented on PR #3:
URL: https://github.com/apache/xerces-j/pull/3#issuecomment-2438112353
@mukulga please review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] [XERCESJ-1763] set Automatic-Module-Name for xercesImpl.jar [xerces-j]
Posted by "SingingBush (via GitHub)" <gi...@apache.org>.
SingingBush commented on code in PR #3:
URL: https://github.com/apache/xerces-j/pull/3#discussion_r2174724884
##########
build.xml:
##########
@@ -351,6 +351,7 @@ Authors:
org/w3c/dom/html/HTMLDOMImplementation.class"
manifest="${build.dir}/manifest.xerces">
<manifest>
+ <attribute name="Automatic-Module-Name" value="org.apache.xerces.impl"/>
Review Comment:
*org.apache.xerces* is probably the best option. I'm happy to make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] [XERCESJ-1763] set Automatic-Module-Name for xercesImpl.jar [xerces-j]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #3:
URL: https://github.com/apache/xerces-j/pull/3#discussion_r2173729005
##########
build.xml:
##########
@@ -351,6 +351,7 @@ Authors:
org/w3c/dom/html/HTMLDOMImplementation.class"
manifest="${build.dir}/manifest.xerces">
<manifest>
+ <attribute name="Automatic-Module-Name" value="org.apache.xerces.impl"/>
Review Comment:
Why not org.apache.xerces?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org
Re: [PR] [XERCESJ-1763] set Automatic-Module-Name for xercesImpl.jar [xerces-j]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #3:
URL: https://github.com/apache/xerces-j/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org