[jira] [Commented] (CASSANDRA-10512) We do not save an upsampled index summaries

["Tyler Hobbs (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-10512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036675#comment-15036675 ] 

Tyler Hobbs commented on CASSANDRA-10512:
-----------------------------------------

The code changes look good to me, with only one nitpick:  in {{MmappedSegmentedFile.copyReadableBounds()}}, you used {{ii}} for the loop index variable instead of the standard {{i}}, for no reason that's apparent to me.

Can you rebase your branches and start new test runs?

> We do not save an upsampled index summaries
> -------------------------------------------
>
>                 Key: CASSANDRA-10512
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10512
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Benedict
>            Assignee: Ariel Weisberg
>             Fix For: 3.0.1, 3.1, 2.1.x, 2.2.x
>
>
> If we downsample an index summary, we overwrite the existing summary, despite downsampling being inexpensive. However on upsampling (which is expensive) we do not, so that on restart all of our index summaries are the smallest they have ever been adjusted to.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)