You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/03/05 00:45:24 UTC
[GitHub] [airflow] potiuk opened a new pull request, #29922: Revert "Decouple production executor warning in dags UI (#29609)"
potiuk opened a new pull request, #29922:
URL: https://github.com/apache/airflow/pull/29922
This reverts commit 88ed20a813393e642de00ec920593bda7b5471cf.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29922:
URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454953933
the right fix is here https://github.com/apache/airflow/pull/29924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29922:
URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454948039
🙏 :) @o-nikolas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29922:
URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454948654
Strange enough it did NOT fail in https://github.com/apache/airflow/pull/29923 ... so I start thinking there could be some intermediate problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #29922:
URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454942880
> @o-nikolas - you will have to redo that one again and we need to carefully look at what was going on with the import.
Interesting, I'll have to find the way to replicate the error on my end. Both my local testing and the PR didn't show the issue. I'll look on Monday. And thanks for the revert 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29922:
URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454950832
I think it is a different thing - side-effect of argcomplete released few moments ago (which drags importlb upgrade with it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29922:
URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454946427
Yep. Strange. I need approval to merge it though :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #29922:
URL: https://github.com/apache/airflow/pull/29922#issuecomment-1456735909
Nice, glad this worked out :smiley: I was unavailable this weekend and only had a few mins to check this PR on my phone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29922:
URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454947217
I also added this one https://github.com/apache/airflow/pull/29923 to clearer show when things like that happen (there will be separate job doing the test collection) and also allowing the other jobs in CI to continue even if collection fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29922:
URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454952959
Confirmed. This is a regrression in importlib_metadata that will be fixed in upcoming celerly 5.3. Workaround is coming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29922:
URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454941979
Not sure why, but I think #https://github.com/apache/airflow/pull/29609 broken pytest collection in main (looks like a circular import). For some reason it did not happen in the original PR.
We should merge it (and find the cause) as both PRs started to fail with:
```
from airflow.executors import celery_executor, celery_kubernetes_executor
airflow/executors/celery_executor.py:40: in <module>
from celery import Celery, Task, states as celery_states
E ImportError: cannot import name 'Celery' from 'celery' (/usr/local/lib/python3.7/site-packages/celery/__init__.py)
```
For example here: https://github.com/apache/airflow/actions/runs/4333507290/jobs/7566768495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29922:
URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454942151
@o-nikolas - you will have to redo that one again and we need to carefully look at what was going on with the import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29922:
URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454953026
(so no need to take a look @o-nikolas )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"
URL: https://github.com/apache/airflow/pull/29922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org