You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/07/07 07:53:47 UTC
[GitHub] [zeppelin] zjffdu opened a new pull request #4166: [ZEPPELIN-5439] Improve the logic of extract hive job url in JdbcInterpreter
zjffdu opened a new pull request #4166:
URL: https://github.com/apache/zeppelin/pull/4166
### What is this PR for?
Previously we extract hive job url from hive jdbc job log, but it seems the in the latest hive, there's no job url info in log.
This PR is use another approach to do that, we use the paragraphId as the hive job yarn tag, after hive sql execution is started, we look at the yarn app that has this tag.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5439
### How should this be tested?
* CI pass
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4166: [ZEPPELIN-5439] Improve the logic of extract hive job url in JdbcInterpreter
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4166:
URL: https://github.com/apache/zeppelin/pull/4166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] cuspymd commented on a change in pull request #4166: [ZEPPELIN-5439] Improve the logic of extract hive job url in JdbcInterpreter
Posted by GitBox <gi...@apache.org>.
cuspymd commented on a change in pull request #4166:
URL: https://github.com/apache/zeppelin/pull/4166#discussion_r665859310
##########
File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
##########
@@ -596,6 +598,24 @@ private String appendProxyUserToURL(String url, String user, String propertyKey)
return connectionUrl.toString();
}
+ // only add tags for hive jdbc
+ private String appendTagsToURL(String url, InterpreterContext context) {
+ StringBuilder builder = new StringBuilder(url);
+ if (url.startsWith("jdbc:hive2:")) {
+ Integer lastIndexOfQMark = builder.indexOf("?");
+ if (lastIndexOfQMark == -1) {
+ builder.append("?");
Review comment:
There seems be no appending "?" mark if it doesn't exit at `appendProxyUserToURL()` line 585~586.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #4166: [ZEPPELIN-5439] Improve the logic of extract hive job url in JdbcInterpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4166:
URL: https://github.com/apache/zeppelin/pull/4166#discussion_r671641058
##########
File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
##########
@@ -596,6 +598,24 @@ private String appendProxyUserToURL(String url, String user, String propertyKey)
return connectionUrl.toString();
}
+ // only add tags for hive jdbc
+ private String appendTagsToURL(String url, InterpreterContext context) {
+ StringBuilder builder = new StringBuilder(url);
+ if (url.startsWith("jdbc:hive2:")) {
+ Integer lastIndexOfQMark = builder.indexOf("?");
+ if (lastIndexOfQMark == -1) {
+ builder.append("?");
Review comment:
Not sure what you mean. User may specify '?' in `default.url`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #4166: [ZEPPELIN-5439] Improve the logic of extract hive job url in JdbcInterpreter
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4166:
URL: https://github.com/apache/zeppelin/pull/4166#issuecomment-892395512
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #4166: [ZEPPELIN-5439] Improve the logic of extract hive job url in JdbcInterpreter
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4166:
URL: https://github.com/apache/zeppelin/pull/4166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org