[GitHub] [incubator-doris] weizuo93 commented on a change in pull request #5665: [Metrics] Add metrics to show the distribution of tablets version count

[GitBox <gi...@apache.org>]

weizuo93 commented on a change in pull request #5665:
URL: https://github.com/apache/incubator-doris/pull/5665#discussion_r616483167



##########
File path: be/src/util/doris_metrics.h
##########
@@ -137,6 +137,20 @@ class DorisMetrics {
     // permits required by the compaction task which is waitting for permits
     IntGauge* compaction_waitting_permits;
 
+    UIntGauge* tablet_version_num_distribution_num;
+    UIntGauge* tablet_version_num_distribution_min;
+    UIntGauge* tablet_version_num_distribution_max;
+    UIntGauge* tablet_version_num_distribution_sum;
+    DoubleGauge* tablet_version_num_distribution_median;
+    DoubleGauge* tablet_version_num_distribution_average;
+    DoubleGauge* tablet_version_num_distribution_standard_deviation;
+    DoubleGauge* tablet_version_num_distribution_p50;
+    DoubleGauge* tablet_version_num_distribution_p75;
+    DoubleGauge* tablet_version_num_distribution_p90;
+    DoubleGauge* tablet_version_num_distribution_p95;
+    DoubleGauge* tablet_version_num_distribution_p99;
+

Review comment:
       > Use HistogramMetric directly, its output is standard now.
   
   OK,  I see it too. PR #5671 has been merged.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org