You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/01 05:00:21 UTC

[GitHub] [incubator-yunikorn-web] akhilpb001 commented on a change in pull request #38: YUNIKORN-46: Add a quick search box in app page

akhilpb001 commented on a change in pull request #38:
URL: https://github.com/apache/incubator-yunikorn-web/pull/38#discussion_r433041836



##########
File path: src/app/components/apps-view/apps-view.component.html
##########
@@ -17,6 +17,25 @@
  -->
 
 <div class="apps-view">
+  <mat-form-field class="search-wrapper white-mat-form-field">

Review comment:
       Usually search will be applied on whole table and its not good ux if we have checkbox for selecting column to be searched.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org