You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/08/26 14:40:35 UTC

Review Request 61924: Moved the 'RejectingObjectApprover' to a public header.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61924/
-----------------------------------------------------------

Review request for mesos and Gastón Kleiman.


Bugs: MESOS-7914
    https://issues.apache.org/jira/browse/MESOS-7914


Repository: mesos


Description
-------

Moved the 'RejectingObjectApprover' to a public header.


Diffs
-----

  src/authorizer/local/authorizer.cpp 82ae846fd39de64704f0e8bd0fe2972f3750d2e6 
  src/common/http.hpp 0e6b1c59860e75c04e2e3be2520ed2b39c84ac90 


Diff: https://reviews.apache.org/r/61924/diff/1/


Testing
-------

`make check`


Thanks,

Greg Mann


Re: Review Request 61924: Moved the 'RejectingObjectApprover' to a public header.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61924/#review183897
-----------------------------------------------------------



Patch looks great!

Reviews applied: [61922, 61923, 61924]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 26, 2017, 7:40 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61924/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2017, 7:40 a.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Bugs: MESOS-7914
>     https://issues.apache.org/jira/browse/MESOS-7914
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved the 'RejectingObjectApprover' to a public header.
> 
> 
> Diffs
> -----
> 
>   src/authorizer/local/authorizer.cpp 82ae846fd39de64704f0e8bd0fe2972f3750d2e6 
>   src/common/http.hpp 0e6b1c59860e75c04e2e3be2520ed2b39c84ac90 
> 
> 
> Diff: https://reviews.apache.org/r/61924/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>