You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/04/21 14:04:49 UTC
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/
-----------------------------------------------------------
(Updated April 21, 2015, 2:04 p.m.)
Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
Repository: mesos
Description
-------
Moves the implementation of StatusUpdateStream to a compilation unit.
Also cleans up headers.
Diffs (updated)
-----
src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
Diff: https://reviews.apache.org/r/33358/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review80972
-----------------------------------------------------------
Ship it!
LGTM assuming no functional changes, just code move.
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/33358/#comment131163>
Do you need them here?
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/33358/#comment131165>
Do we need this include here?
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/33358/#comment131164>
Shall this include stay here?
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/33358/#comment131157>
Not yours, but let's remove empty newlines.
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/33358/#comment131158>
`#include <process/future.hpp>?
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/33358/#comment131159>
`#include <mesos/mesos.hpp>`?
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/33358/#comment131160>
`#include <stout/try.hpp>?`
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/33358/#comment131161>
Why have you left this one here? It's more than one line, I think you can move it to `.cpp` as well.
src/slave/status_update_manager.hpp
<https://reviews.apache.org/r/33358/#comment131162>
`#include <stout/option.hpp>`?
- Alexander Rukletsov
On April 21, 2015, 12:38 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33358/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 12:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2609
> https://issues.apache.org/jira/browse/MESOS-2609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves the implementation of StatusUpdateStream to a compilation unit.
> Also cleans up headers.
>
>
> Diffs
> -----
>
> src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/33358/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review81137
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33358]
All tests passed.
- Mesos ReviewBot
On April 22, 2015, 9:09 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33358/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 9:09 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2609
> https://issues.apache.org/jira/browse/MESOS-2609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves the implementation of StatusUpdateStream to a compilation unit.
> Also cleans up headers.
>
>
> Diffs
> -----
>
> src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/33358/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Ben Mahler <be...@gmail.com>.
> On April 22, 2015, 9:24 a.m., Alexander Rukletsov wrote:
> > Let's not repeat summary in description. How about the following:
> > "StatusUpdateStream is not a template, hence we can reduce compilation time by moving method definitions into a `.cpp` file. As a drive-by change headers are cleaned up."
> >
> > Thank you for putting effort into reducing compilation time!
> Thank you for putting effort into reducing compilation time!
Was it measured? :)
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review81136
-----------------------------------------------------------
On April 22, 2015, 9:09 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33358/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 9:09 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2609
> https://issues.apache.org/jira/browse/MESOS-2609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves the implementation of StatusUpdateStream to a compilation unit.
> Also cleans up headers.
>
>
> Diffs
> -----
>
> src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/33358/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On April 22, 2015, 11:24 a.m., Alexander Rukletsov wrote:
> > Let's not repeat summary in description. How about the following:
> > "StatusUpdateStream is not a template, hence we can reduce compilation time by moving method definitions into a `.cpp` file. As a drive-by change headers are cleaned up."
> >
> > Thank you for putting effort into reducing compilation time!
>
> Ben Mahler wrote:
> > Thank you for putting effort into reducing compilation time!
>
> Was it measured? :)
I did measure it, but status_update_manager is not widely included, so in practice there was not really performance gain. Still I think it's not only about compilation time, but reducing the ammount of inlined code.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review81136
-----------------------------------------------------------
On April 22, 2015, 11:09 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33358/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 11:09 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2609
> https://issues.apache.org/jira/browse/MESOS-2609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves the implementation of StatusUpdateStream to a compilation unit.
> Also cleans up headers.
>
>
> Diffs
> -----
>
> src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/33358/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review81136
-----------------------------------------------------------
Ship it!
Let's not repeat summary in description. How about the following:
"StatusUpdateStream is not a template, hence we can reduce compilation time by moving method definitions into a `.cpp` file. As a drive-by change headers are cleaned up."
Thank you for putting effort into reducing compilation time!
- Alexander Rukletsov
On April 22, 2015, 9:09 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33358/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 9:09 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2609
> https://issues.apache.org/jira/browse/MESOS-2609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves the implementation of StatusUpdateStream to a compilation unit.
> Also cleans up headers.
>
>
> Diffs
> -----
>
> src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/33358/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review81304
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On April 22, 2015, 9:09 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33358/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 9:09 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2609
> https://issues.apache.org/jira/browse/MESOS-2609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves the implementation of StatusUpdateStream to a compilation unit.
> Also cleans up headers.
>
>
> Diffs
> -----
>
> src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/33358/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review83113
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33358]
All tests passed.
- Mesos ReviewBot
On May 8, 2015, 10:11 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33358/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 10:11 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2609
> https://issues.apache.org/jira/browse/MESOS-2609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves the implementation of StatusUpdateStream to a compilation unit.
> Also cleans up headers.
>
>
> Diffs
> -----
>
> src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/33358/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review86207
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33358]
All tests passed.
- Mesos ReviewBot
On June 2, 2015, 10:24 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33358/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 10:24 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2609
> https://issues.apache.org/jira/browse/MESOS-2609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves the implementation of StatusUpdateStream to a compilation unit.
> Also cleans up headers.
>
>
> Diffs
> -----
>
> src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/33358/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/
-----------------------------------------------------------
(Updated June 2, 2015, 12:24 p.m.)
Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
Changes
-------
rebased
Bugs: MESOS-2609
https://issues.apache.org/jira/browse/MESOS-2609
Repository: mesos
Description
-------
Moves the implementation of StatusUpdateStream to a compilation unit.
Also cleans up headers.
Diffs (updated)
-----
src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
Diff: https://reviews.apache.org/r/33358/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/
-----------------------------------------------------------
(Updated May 9, 2015, 12:11 a.m.)
Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
Changes
-------
rebased to current head.
Bugs: MESOS-2609
https://issues.apache.org/jira/browse/MESOS-2609
Repository: mesos
Description
-------
Moves the implementation of StatusUpdateStream to a compilation unit.
Also cleans up headers.
Diffs (updated)
-----
src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
Diff: https://reviews.apache.org/r/33358/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review82897
-----------------------------------------------------------
Ship it!
Ship It!
- Joerg Schad
On April 22, 2015, 9:09 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33358/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 9:09 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2609
> https://issues.apache.org/jira/browse/MESOS-2609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves the implementation of StatusUpdateStream to a compilation unit.
> Also cleans up headers.
>
>
> Diffs
> -----
>
> src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/33358/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/
-----------------------------------------------------------
(Updated April 22, 2015, 11:09 a.m.)
Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
Changes
-------
Adresses Alex's comments.
Bugs: MESOS-2609
https://issues.apache.org/jira/browse/MESOS-2609
Repository: mesos
Description
-------
Moves the implementation of StatusUpdateStream to a compilation unit.
Also cleans up headers.
Diffs (updated)
-----
src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
Diff: https://reviews.apache.org/r/33358/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/#review80971
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33358]
All tests passed.
- Mesos ReviewBot
On April 21, 2015, 12:38 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33358/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 12:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
>
>
> Bugs: MESOS-2609
> https://issues.apache.org/jira/browse/MESOS-2609
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moves the implementation of StatusUpdateStream to a compilation unit.
> Also cleans up headers.
>
>
> Diffs
> -----
>
> src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
> src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
>
> Diff: https://reviews.apache.org/r/33358/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33358: Moved implementation of StatusUpdateStream
to a compilation unit.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33358/
-----------------------------------------------------------
(Updated April 21, 2015, 2:38 p.m.)
Review request for mesos, Alexander Rukletsov, Joerg Schad, and Till Toenshoff.
Changes
-------
Adding JIRA Issue.
Bugs: MESOS-2609
https://issues.apache.org/jira/browse/MESOS-2609
Repository: mesos
Description
-------
Moves the implementation of StatusUpdateStream to a compilation unit.
Also cleans up headers.
Diffs
-----
src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54
src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4
Diff: https://reviews.apache.org/r/33358/diff/
Testing
-------
make check
Thanks,
Alexander Rojas