[GitHub] [spark] revans2 commented on a change in pull request #24795: [SPARK-27945][SQL] Minimal changes to support columnar processing

[GitBox <gi...@apache.org>]

revans2 commented on a change in pull request #24795: [SPARK-27945][SQL] Minimal changes to support columnar processing
URL: https://github.com/apache/spark/pull/24795#discussion_r299008558
 
 

 ##########
 File path: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
 ##########
 @@ -604,7 +604,10 @@ public final int appendArray(int length) {
    */
   public final int appendStruct(boolean isNull) {
     if (isNull) {
-      appendNull();
+      // This is the same as appendNull but without the assertion for struct types
 
 Review comment:
   Because `appendNull` itself has an assertion that you are not appending a struct.  So any call to `appendStruct` with `isNull` true would have failed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org