You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/12/27 23:45:52 UTC
Review Request 16492: Added a script to tag a release candidate and upload
the jar.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16492/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-756
https://issues.apache.org/jira/browse/MESOS-756
Repository: mesos-git
Description
-------
This is part 1 in MESOS-756.
Diffs
-----
support/tag.sh PRE-CREATION
Diff: https://reviews.apache.org/r/16492/diff/
Testing
-------
Tested locally.
Thanks,
Vinod Kone
Re: Review Request 16492: Added a script to tag a release candidate and
upload the jar.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16492/#review32064
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Jan. 15, 2014, 2:48 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16492/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 2:48 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-756
> https://issues.apache.org/jira/browse/MESOS-756
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 1 in MESOS-756.
>
>
> Diffs
> -----
>
> support/tag.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16492/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 16492: Added a script to tag a release candidate and
upload the jar.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16492/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 2:48 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's.
Bugs: MESOS-756
https://issues.apache.org/jira/browse/MESOS-756
Repository: mesos-git
Description
-------
This is part 1 in MESOS-756.
Diffs (updated)
-----
support/tag.sh PRE-CREATION
Diff: https://reviews.apache.org/r/16492/diff/
Testing
-------
Tested locally.
Thanks,
Vinod Kone
Re: Review Request 16492: Added a script to tag a release candidate and
upload the jar.
Posted by Vinod Kone <vi...@gmail.com>.
> On Jan. 10, 2014, 8:02 p.m., Ben Mahler wrote:
> > support/tag.sh, lines 53-55
> > <https://reviews.apache.org/r/16492/diff/1/?file=403953#file403953line53>
> >
> > I'm wondering why the tagging and voting scripts both upload to maven? Shouldn't it be at tagging time only, or are you trying to be robust in the vote script?
> >
> > If it's the latter, what about sharing the code for publishing a JAR in a common script file?
As discussed offline this is because tagging creates a jar that includes release candidate (e.g. mesos-0.16.0-rc2.jar) whereas voting creates a jar that doesn't (e.g. mesos-0.16.0.jar)
> On Jan. 10, 2014, 8:02 p.m., Ben Mahler wrote:
> > support/tag.sh, line 50
> > <https://reviews.apache.org/r/16492/diff/1/?file=403953#file403953line50>
> >
> > It would be nice if we had a little utility to compute the argument to -j in these scripts, e.g.:
> > http://stackoverflow.com/a/4778475
> >
> > Passing a -l argument to limit load might be nice as well.
i'm punting on it for now since i couldn't find an elegant solution that works on both osx and linux. also the load average is not normalized so we still need to calculate the number of cpus.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16492/#review31533
-----------------------------------------------------------
On Dec. 27, 2013, 10:45 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16492/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2013, 10:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-756
> https://issues.apache.org/jira/browse/MESOS-756
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 1 in MESOS-756.
>
>
> Diffs
> -----
>
> support/tag.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16492/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 16492: Added a script to tag a release candidate and
upload the jar.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16492/#review31533
-----------------------------------------------------------
support/tag.sh
<https://reviews.apache.org/r/16492/#comment60047>
It would be nice if we had a little utility to compute the argument to -j in these scripts, e.g.:
http://stackoverflow.com/a/4778475
Passing a -l argument to limit load might be nice as well.
support/tag.sh
<https://reviews.apache.org/r/16492/#comment60044>
I'm wondering why the tagging and voting scripts both upload to maven? Shouldn't it be at tagging time only, or are you trying to be robust in the vote script?
If it's the latter, what about sharing the code for publishing a JAR in a common script file?
- Ben Mahler
On Dec. 27, 2013, 10:45 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16492/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2013, 10:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-756
> https://issues.apache.org/jira/browse/MESOS-756
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 1 in MESOS-756.
>
>
> Diffs
> -----
>
> support/tag.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16492/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Vinod Kone
>
>