You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/04/02 05:35:00 UTC

[GitHub] [hadoop] virajjasani commented on pull request #2830: HDFS-15931. Fix non-static inner classes for better memory management

virajjasani commented on pull request #2830:
URL: https://github.com/apache/hadoop/pull/2830#issuecomment-812329113


   > @virajjasani Just saw you have multiple PRs recently. In Hadoop, the PR title and git commit subject have format:
   > 
   > ```
   > HADOOP-12345. Fix foo. Contributed by Viraj
   > ```
   > 
   > So the `.` instead of ` :`. I personally am fine with either char, but looks like the convention is to have `.` instead of space and colon ` :` to join the JIRA number and subject.
   
   Thanks @liuml07 , I will take care of this going forward. One question: `Contributed by user` should be in PR title? Or that is something taken care of while merging PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org