[GitHub] sijie closed pull request #1383: Fix format problem of BP-32

[GitBox <gi...@apache.org>]

sijie closed pull request #1383: Fix format problem of BP-32
URL: https://github.com/apache/bookkeeper/pull/1383
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/site/bps/BP-32-advisory-write-close.md b/site/bps/BP-32-advisory-write-close.md
index f3d0ffcfb..afe8e971f 100644
--- a/site/bps/BP-32-advisory-write-close.md
+++ b/site/bps/BP-32-advisory-write-close.md
@@ -7,7 +7,7 @@ release: N/A
 
 ### Motivation
 
-With entrylog per ledger feature (https://github.com/apache/bookkeeper/issues/570) there will be dedicated entrylog for each ledger and it provides EntryLogManagerForEntryLogPerLedger (EntryLogManager). Since there is going to be entrylog per ledger, with the current Bookie implementation there is no way for EntryLogManagerForEntryLogPerLedger (EntryLogManager) to know when the entrylog is writeclosed, so that entrylog for the active ledger can be rotated. So it would be ideal to have explicit call to EntryLogger when the write for this ledger is done and it is writeclosed, so that it can rotate the entrylog as soon as it is write closed. This will minimize the number of entrylogs/file descriptors that are open/active and also it will make progress in leastUnflushedLogId, so that GarbageCollectorThread can consider these entrylogs for garbage collection.
+With [entrylog per ledger feature](https://github.com/apache/bookkeeper/issues/570) there will be dedicated entrylog for each ledger and it provides EntryLogManagerForEntryLogPerLedger (EntryLogManager). Since there is going to be entrylog per ledger, with the current Bookie implementation there is no way for EntryLogManagerForEntryLogPerLedger (EntryLogManager) to know when the entrylog is writeclosed, so that entrylog for the active ledger can be rotated. So it would be ideal to have explicit call to EntryLogger when the write for this ledger is done and it is writeclosed, so that it can rotate the entrylog as soon as it is write closed. This will minimize the number of entrylogs/file descriptors that are open/active and also it will make progress in leastUnflushedLogId, so that GarbageCollectorThread can consider these entrylogs for garbage collection.
 
 ### Proposed Changes
 
@@ -29,6 +29,7 @@ EntryLogManagerForEntryLogPerLedger is the class which is last layer in the stac
 
 As explained above, this advisory write close should be transparent to Bookkeeper API user, this should be piggybagged in writehandle close call and other internal Bookie / BookieClient internal class methods (ReadEntryProcessorV3.readrequest and LedgerFragmentReplicator). But this feature introduces new protobuf message between Client and Bookie.
 
+```
 message WriteCloseRequest {
     required int64 ledgerId = 1;
     required bytes masterKey = 2;    
@@ -38,6 +39,7 @@ message WriteCloseResponse {
     required StatusCode status = 1;
     required int64 ledgerId = 2;  
 }
+```
 
 ### Compatibility, Deprecation, and Migration Plan
 
diff --git a/site/community/bookkeeper_proposals.md b/site/community/bookkeeper_proposals.md
index b9f439693..dc2fe99c2 100644
--- a/site/community/bookkeeper_proposals.md
+++ b/site/community/bookkeeper_proposals.md
@@ -103,7 +103,7 @@ Proposal | State
 [BP-29: Metadata API module](../../bps/BP-29-metadata-store-api-module) | Accepted
 [BP-30: BookKeeper Table Service](https://docs.google.com/document/d/155xAwWv5IdOitHh1NVMEwCMGgB28M3FyMiQSxEpjE-Y/edit#heading=h.56rbh52koe3f) | Accepted
 [BP-31: BookKeeper Durability Anchor](../../bps/BP-31-durability) | Accepted
-[BP-32: Advisory (optimistic) write close](../../bps/BP-32-advisory-write-close) | Draft
+[BP-32: Advisory (optimistic) write close](../../bps/BP-32-advisory-write-close) | Accepted
 
 ### Adopted
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services