You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2014/11/29 23:08:32 UTC
svn commit: r1642479 -
/pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/xml/DomXmpParser.java
Author: tilman
Date: Sat Nov 29 22:08:32 2014
New Revision: 1642479
URL: http://svn.apache.org/r1642479
Log:
PDFBOX-2485: don't swallow IllegalArgumentException; rethrow as XmpParsingException with details
Modified:
pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/xml/DomXmpParser.java
Modified: pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/xml/DomXmpParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/xml/DomXmpParser.java?rev=1642479&r1=1642478&r2=1642479&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/xml/DomXmpParser.java (original)
+++ pdfbox/trunk/xmpbox/src/main/java/org/apache/xmpbox/xml/DomXmpParser.java Sat Nov 29 22:08:32 2014
@@ -262,10 +262,10 @@ public class DomXmpParser
attr.getLocalName(), attr.getValue(), type.type());
container.addProperty(sp);
}
- catch( IllegalArgumentException exception)
+ catch (IllegalArgumentException e)
{
- //Swallow, and continue adding additional properties
- LOG.warn("Unable to add property: "+ attr.getLocalName() + " value: "+attr.getValue(),exception);
+ throw new XmpParsingException(ErrorType.Format,
+ e.getMessage() + " in " + schema.getPrefix() + ":" + attr.getLocalName(), e);
}
}
}
@@ -382,6 +382,10 @@ public class DomXmpParser
}
}
}
+ catch (IllegalArgumentException e)
+ {
+ throw new XmpParsingException(ErrorType.Format, e.getMessage() + " in " + prefix + ":" + name, e);
+ }
finally
{
nsFinder.pop();