You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tzolov <gi...@git.apache.org> on 2014/07/22 16:17:05 UTC
[GitHub] spark pull request: [Build] SPARK-2619: Configurable filemode for ...
GitHub user tzolov opened a pull request:
https://github.com/apache/spark/pull/1531
[Build] SPARK-2619: Configurable filemode for the spark/bin folder in debian package
Add a `<deb.bin.filemode>744</deb.bin.filemode>` property to the `assembly/pom.xml` that defaults to `744`.
Use this property for ../bin folder <filemode>.
This patch doesn't change the current default modes but allows one override the modes at build time:
`-Ddeb.bin.filemode=<new mode>`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzolov/spark SPARK-2619
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1531.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1531
----
commit 6d953435a92f9b871d7a8d3d5cb8c65619c58880
Author: tzolov <ch...@gmail.com>
Date: 2014-07-22T14:08:58Z
[Build] SPARK-2619: Configurable filemode for the spark/bin folder in the .deb package
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [Build] SPARK-2619: Configurable filemode for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1531
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [Build] SPARK-2619: Configurable filemode for ...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1531#issuecomment-50055648
seems like a good idea. I can merge this. Unfortunately this debian build isn't really maintained at the moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [Build] SPARK-2619: Configurable filemode for ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1531#issuecomment-49745346
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---