[GitHub] csantanapr commented on a change in pull request #3731: Relax connection retry in invoker

[GitBox <gi...@apache.org>]

csantanapr commented on a change in pull request #3731: Relax connection retry in invoker
URL: https://github.com/apache/incubator-openwhisk/pull/3731#discussion_r194412583
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/containerpool/HttpUtils.scala
 ##########
 @@ -126,9 +126,8 @@ protected[core] class HttpUtils(hostname: String, timeout: FiniteDuration, maxRe
     } match {
       case Success(response) => response
       case Failure(t: RetryableConnectionError) if retry =>
-        val sleepTime = 10.milliseconds
+        val sleepTime = 50.milliseconds
 
 Review comment:
   @sven-lange-last Can this hardcoded value value be be a configuration setting that can be overload thru prureconfig/environment-variable?
   
   It was originally to retry every 100ms, then it was changed to 10ms, and now every 50ms, 
   In case 50ms also makes the invokers slower overall and need to be adjusted again, doing on config is more manageable. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services