You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/05/11 14:13:09 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #852: SOLR-15739: Convert v2 GET /get API to annotations (#677)
gerlowskija opened a new pull request, #852:
URL: https://github.com/apache/solr/pull/852
https://issues.apache.org/jira/browse/SOLR-15739
# Description
Solr's been in the slow process of moving its v2 APIs away from the
existing apispec/mapping framework towards one that relies on more
explicit annotations to specify API properties.
# Solution
This commit converts the APIs from the core.RealtimeGet apispec files to
the "new" framework.
# Tests
N/A - existing tests sufficient to validate this refactor.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #852: SOLR-15739: Convert v2 GET /get API to annotations (#677)
Posted by GitBox <gi...@apache.org>.
gerlowskija merged PR #852:
URL: https://github.com/apache/solr/pull/852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a diff in pull request #852: SOLR-15739: Convert v2 GET /get API to annotations (#677)
Posted by GitBox <gi...@apache.org>.
dsmiley commented on code in PR #852:
URL: https://github.com/apache/solr/pull/852#discussion_r873296358
##########
solr/core/src/java/org/apache/solr/handler/RealTimeGetHandler.java:
##########
@@ -51,7 +53,7 @@ public String getDescription() {
@Override
public Collection<Api> getApis() {
- return ApiBag.wrapRequestHandlers(this, "core.RealtimeGet");
+ return Lists.newArrayList(AnnotatedApi.getApis(new RealTimeGetAPI(this)));
Review Comment:
Please avoid Guava for this; I think you can simply use List.of even though it's immutable (probably a good thing). I know this PR is merged; my comment is for your future consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org