You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/22 10:19:39 UTC
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1636: Move OneOffJobBootstrap.triggerAllInstances into InstanceService
codecov-io commented on pull request #1636:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1636#issuecomment-714392215
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636?src=pr&el=h1) Report
> Merging [#1636](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/cce1e6710c09241bde34d7f00f183215f9bad9e0?el=desc) will **decrease** coverage by `0.17%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1636 +/- ##
============================================
- Coverage 85.99% 85.81% -0.18%
Complexity 102 102
============================================
Files 247 247
Lines 5641 5641
Branches 873 872 -1
============================================
- Hits 4851 4841 -10
- Misses 478 487 +9
- Partials 312 313 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ob/lite/api/bootstrap/impl/OneOffJobBootstrap.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvYXBpL2Jvb3RzdHJhcC9pbXBsL09uZU9mZkpvYkJvb3RzdHJhcC5qYXZh) | `64.28% <60.00%> (-18.07%)` | `0.00 <0.00> (ø)` | |
| [...lasticjob/lite/internal/instance/InstanceNode.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvaW5zdGFuY2UvSW5zdGFuY2VOb2RlLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ticjob/lite/internal/instance/InstanceService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvaW5zdGFuY2UvSW5zdGFuY2VTZXJ2aWNlLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../elasticjob/lite/internal/storage/JobNodePath.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc3RvcmFnZS9Kb2JOb2RlUGF0aC5qYXZh) | `77.77% <0.00%> (-22.23%)` | `0.00% <0.00%> (ø%)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `77.77% <0.00%> (-4.77%)` | `1.00% <0.00%> (ø%)` | |
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636?src=pr&el=footer). Last update [cce1e67...0440525](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1636?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org