You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/04/22 19:10:35 UTC

[GitHub] [couchdb] jiahuili430 commented on a diff in pull request #3990: Creating index with empty "name"/"ddoc" should return 400

jiahuili430 commented on code in PR #3990:
URL: https://github.com/apache/couchdb/pull/3990#discussion_r856502513


##########
src/mango/test/01-index-crud-test.py:
##########
@@ -68,17 +68,17 @@ def test_bad_types(self):
             else:
                 raise AssertionError("bad create index")
 
-    def test_bad_names(self):
-        bad_names = [True, False, 1.5, {"foo": "bar"}, [None, False]]
-        for bn in bad_names:
+    def test_bad_names_ddocs(self):
+        bad_args = ["", True, False, 1.5, {"foo": "bar"}, [None, False]]

Review Comment:
   Added another test case [test_bad_ddocs()](https://github.com/apache/couchdb/pull/3990/files#diff-243cff897c08c3a4b060fed2dc84a22d35740500fbf075e6209ba5013f0fd7faR81), thanks for the review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org