You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/06 08:07:09 UTC
[GitHub] [spark] beliefer opened a new pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
beliefer opened a new pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829
### What changes were proposed in this pull request?
This PR follows https://github.com/apache/spark/pull/27691, https://github.com/apache/spark/pull/27730 and https://github.com/apache/spark/pull/27770
I sorted out some information show below.
Item name | Since version | JIRA ID | Commit ID | Note
-- | -- | -- | -- | --
spark.sql.redaction.options.regex | 2.2.2 | SPARK-23850 | 6a55d8b03053e616dcacb79cd2c29a06d219dc32#diff-9a6b543db706f1a90f790783d6930a13 | Begin
spark.sql.redaction.string.regex | 2.3.0 | SPARK-22791 | 28315714ddef3ddcc192375e98dd5207cf4ecc98#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.function.concatBinaryAsString | 2.3.0 | SPARK-22771 | f2b3525c17d660cf6f082bbafea8632615b4f58e#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.function.eltOutputAsString | 2.3.0 | SPARK-22937 | bf853018cabcd3b3abf84bfe534d2981020b4a71#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.sources.validatePartitionColumns | 3.0.0 | SPARK-26263 | 5a140b7844936cf2b65f08853b8cfd8c499d4f13#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.streaming.continuous.epochBacklogQueueSize | 3.0.0 | SPARK-24063 | c4bbfd177b4e7cb46f47b39df9fd71d2d9a12c6d#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.streaming.continuous.executorQueueSize | 2.3.0 | SPARK-22789 | 8941a4abcada873c26af924e129173dc33d66d71#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.streaming.continuous.executorPollIntervalMs | 2.3.0 | SPARK-22789 | 8941a4abcada873c26af924e129173dc33d66d71#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.sources.useV1SourceList | 3.0.0 | SPARK-28747 | cb06209fc908bac6ce6a8f20653865489773cbc3#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.streaming.disabledV2Writers | 2.3.1 | SPARK-23196 | 588b9694c1967ff45774431441e84081ee6eb515#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.streaming.disabledV2MicroBatchReaders | 2.4.0 | SPARK-23362 | 0a73aa31f41c83503d5d99eff3c9d7b406014ab3#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.sources.partitionOverwriteMode | 2.3.0 | SPARK-20236 | b96248862589bae1ddcdb14ce4c802789a001306#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.storeAssignmentPolicy | 3.0.0 | SPARK-28730 | 895c90b582cc2b2667241f66d5b733852aeef9eb#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.ansi.enabled | 3.0.0 | SPARK-30125 | d9b30694122f8716d3acb448638ef1e2b96ebc7a#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.execution.sortBeforeRepartition | 2.1.4 | SPARK-23207 and SPARK-22905 and SPARK-24564 and SPARK-25114 | 4d2d3d47e00e78893b1ecd5a9a9070adc5243ac9#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.optimizer.nestedSchemaPruning.enabled | 2.4.1 | SPARK-4502 | dfcff38394929970fee454c69864d0e10d59f8d4#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.optimizer.serializer.nestedSchemaPruning.enabled | 3.0.0 | SPARK-26837 | 0f2c0b53e8fb18c86c67b5dd679c006db93f94a5#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.optimizer.expression.nestedPruning.enabled | 3.0.0 | SPARK-27707 | 127bc899ae78d73332a87f0972b5db3c9936c1f1#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.execution.topKSortFallbackThreshold | 2.4.0 | SPARK-24193 | 8a837bf4f3f2758f7825d2362cf9de209026651a#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.csv.parser.columnPruning.enabled | 2.4.0 | SPARK-24244 and SPARK-24368 | 64fad0b519cf35b8c0a0dec18dd3df9488a5ed25#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.repl.eagerEval.enabled | 2.4.0 | SPARK-24215 | 6a0b77a55d53e74ac0a0892556c3a7a933474948#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.repl.eagerEval.maxNumRows | 2.4.0 | SPARK-24215 | 6a0b77a55d53e74ac0a0892556c3a7a933474948#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.repl.eagerEval.truncate | 2.4.0 | SPARK-24215 | 6a0b77a55d53e74ac0a0892556c3a7a933474948#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.codegen.aggregate.fastHashMap.capacityBit | 2.4.0 | SPARK-24978 | 6193a202aab0271b4532ee4b740318290f2c44a1#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.avro.compression.codec | 2.4.0 | SPARK-24881 | 0a0f68bae6c0a1bf30184b1e9ac6bf3805bd7511#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.avro.deflate.level | 2.4.0 | SPARK-24881 | 0a0f68bae6c0a1bf30184b1e9ac6bf3805bd7511#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.sizeOfNull | 2.4.0 | SPARK-24605 | d08f53dc61f662f5291f71bcbe1a7b9f531a34d2#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.replaceDatabricksSparkAvro.enabled | 2.4.0 | SPARK-25129 | ac0174e55af2e935d41545721e9f430c942b3a0c#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.setopsPrecedence.enabled | 2.4.0 | SPARK-24966 | 73dd6cf9b558f9d752e1f3c13584344257ad7863#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.exponentLiteralAsDecimal.enabled | 3.0.0 | SPARK-29956 | 87ebfaf003fcd05a7f6d23b3ecd4661409ce5f2f#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.allowNegativeScaleOfDecimal | 3.0.0 | SPARK-30812 | b76bc0b1b8b2abd00a84f805af90ca4c5925faaa#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.createHiveTableByDefault.enabled | 3.0.0 | SPARK-30098 | 58be82ad4b98fc17e821e916e69e77a6aa36209d#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.integralDivide.returnBigint | 3.0.0 | SPARK-25457 | 47d6e80a2e64823fabb596503fb6a6cc6f51f713#diff-9a6b543db706f1a90f790783d6930a13 | Exists in branch-3.0 branch, but the pom.xml file corresponding to the commit log is 2.5.0-SNAPSHOT
spark.sql.legacy.bucketedTableScan.outputOrdering | 3.0.0 | SPARK-28595 | 469423f33887a966aaa33eb75f5e7974a0a97beb#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.parser.havingWithoutGroupByAsWhere | 2.4.1 | SPARK-25708 | 3dba5d41f1a66ae5eb08404d103284110c45a351#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.json.allowEmptyString.enabled | 3.0.0 | SPARK-25040 | d3de7568f32e298442f07b0a28b2c906de72c797#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.createEmptyCollectionUsingStringType | 3.0.0 | SPARK-30790 | 8ab6ae3ede96adb093347470a5cbbf17fe8c04e9#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.allowUntypedScalaUDF | 3.0.0 | SPARK-26580 | bc30a07ce262840c99a752db4fbd3a423f652017#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.truncateTable.ignorePermissionAcl.enabled | 2.4.6 | SPARK-30312 | 830a4ec59b86253f18eb7dfd6ed0bbe0d7920e5b#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.dataset.nameNonStructGroupingKeyAsValue | 3.0.0 | SPARK-26085 | ab2eafb3cdc7631452650c6cac03a92629255347#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.debug.maxToStringFields | 3.0.0 | SPARK-26066 | 81550b38e43fb20f89f529d2127575c71a54a538#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.maxPlanStringLength | 3.0.0 | SPARK-26103 | 812ad5546148d2194ab0e4230ee85b8f6a5be2fb#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.setCommandRejectsSparkCoreConfs | 3.0.0 | SPARK-26060 | 1ab3d3e474ce2e36d58aea8ad09fb61f0c73e5c5#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.datetime.java8API.enabled | 3.0.0 | SPARK-27008 | 52671d631d2a64ed1cfa0c6e01168908faf92df8#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.sources.binaryFile.maxLength | 3.0.0 | SPARK-27588 | 618d6bff71073c8c93501ab7392c3cc579730f0b#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.typeCoercion.datetimeToString.enabled | 3.0.0 | SPARK-27638 | 83d289eef492de8c7f3e5145f9bd75431608b500#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.defaultCatalog | 3.0.0 | SPARK-29753 | 942753a44beeae5f0142ceefa307e90cbc1234c5#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.catalog.$SESSION_CATALOG_NAME | 3.0.0 | SPARK-29412 | 9407fba0375675d6ee6461253f3b8230e8d67509#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.doLooseUpcast | 3.0.0 | SPARK-30812 | b76bc0b1b8b2abd00a84f805af90ca4c5925faaa#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.ctePrecedencePolicy | 3.0.0 | SPARK-30829 | 00943be81afbca6be13e1e72b24536cd98a788d6#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.timeParserPolicy | 3.1.0 | SPARK-30668 | 7db0af578585ecaeee9fd23f8189292289b52a97#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.followThreeValuedLogicInArrayExists | 3.0.0 | SPARK-30812 | b76bc0b1b8b2abd00a84f805af90ca4c5925faaa#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.maven.additionalRemoteRepositories | 3.0.0 | SPARK-29175 | 3d7359ad4202067b26a199657b6a3e1f38be0e4d#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.fromDayTimeString.enabled | 3.0.0 | SPARK-29864 and SPARK-29920 | e933539cdd557297daf97ff5e532a3f098896979#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.notReserveProperties | 3.0.0 | SPARK-30812 | b76bc0b1b8b2abd00a84f805af90ca4c5925faaa#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.addSingleFileInAddFile | 3.0.0 | SPARK-30234 | 8a8d1fbb10af6da481f26831cd519ef46ccbce6c#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.mssqlserver.numericMapping.enabled | 2.4.5 | SPARK-28152 | 69de7f31c37a7e0298e66cc814afc1b0aa948bbb#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.csv.filterPushdown.enabled | 3.0.0 | SPARK-30323 | 4e50f0291f032b4a5c0b46ed01fdef14e4cbb050#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.addPartitionInBatch.size | 3.0.0 | SPARK-29938 | 5ccbb38a71890b114c707279e7395d1f6284ebfd#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.timeParser.enabled | 3.0.0 | SPARK-30668 | 92f57237871400ab9d499e1174af22a867c01988#diff-9a6b543db706f1a90f790783d6930a13 |
spark.sql.legacy.allowDuplicatedMapKeys | 3.0.0 | SPARK-25829 | 33329caa81827a245b84158b13234b88a4746e56#diff-9a6b543db706f1a90f790783d6930a13 |
### Why are the changes needed?
Supplemental configuration version information.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Exists UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388767577
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2164,7 +2164,7 @@ object SQLConf {
.internal()
.doc("If it is set to true, the data source provider com.databricks.spark.avro is mapped " +
"to the built-in but external Avro data source module for backward compatibility.")
- .version("")
+ .version("2.4.0")
Review comment:
SPARK-25129, commit ID: ac0174e55af2e935d41545721e9f430c942b3a0c#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388764766
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2102,7 +2102,7 @@ object SQLConf {
"Jupyter, the HTML table (generated by _repr_html_) will be returned. For plain Python " +
"REPL, the returned outputs are formatted like dataframe.show(). In SparkR, the returned " +
"outputs are showed similar to R data.frame would.")
- .version("")
+ .version("2.4.0")
Review comment:
SPARK-24215, commit ID: 6a0b77a55d53e74ac0a0892556c3a7a933474948#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388770219
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2294,7 +2294,7 @@ object SQLConf {
"longer, further output will be truncated. The default setting always generates a full " +
"plan. Set this to a lower value such as 8k if plan strings are taking up too much " +
"memory or are causing OutOfMemory errors in the driver or UI processes.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-26103, commit ID: 812ad5546148d2194ab0e4230ee85b8f6a5be2fb#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388767243
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2146,7 +2146,7 @@ object SQLConf {
.doc("Compression level for the deflate codec used in writing of AVRO files. " +
"Valid value must be in the range of from 1 to 9 inclusive or -1. " +
"The default value is -1 which corresponds to 6 level in the current implementation.")
- .version("")
+ .version("2.4.0")
Review comment:
SPARK-24881, commit ID: 0a0f68bae6c0a1bf30184b1e9ac6bf3805bd7511#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388762030
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1886,20 +1886,20 @@ object SQLConf {
"information. When this regex matches a string part, that string part is replaced by a " +
"dummy value. This is currently used to redact the output of SQL explain commands. " +
"When this conf is not set, the value from `spark.redaction.string.regex` is used.")
- .version("")
+ .version("2.3.0")
Review comment:
SPARK-22791, commit ID: 28315714ddef3ddcc192375e98dd5207cf4ecc98#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388762948
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1936,7 +1936,7 @@ object SQLConf {
.internal()
.doc("The interval at which continuous execution readers will poll to check whether" +
" the epoch has advanced on the driver.")
- .version("")
+ .version("2.3.0")
Review comment:
SPARK-22789, commit ID: 8941a4abcada873c26af924e129173dc33d66d71#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388762474
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1910,15 +1910,15 @@ object SQLConf {
"user-specified schema. If the validation fails, a runtime exception is thrown. " +
"When this option is set to false, the partition column value will be converted to null " +
"if it can not be casted to corresponding user-specified schema.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-26263, commit ID: 5a140b7844936cf2b65f08853b8cfd8c499d4f13#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388854221
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2374,7 +2374,7 @@ object SQLConf {
val LEGACY_LOOSE_UPCAST = buildConf("spark.sql.legacy.doLooseUpcast")
.internal()
.doc("When true, the upcast will be loose and allows string to atomic types.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-30812, commit ID: b76bc0b1b8b2abd00a84f805af90ca4c5925faaa#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388785815
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2352,7 +2352,7 @@ object SQLConf {
s"be loaded by the $SESSION_CATALOG_NAME, this catalog must also return the table " +
s"metadata. To delegate operations to the $SESSION_CATALOG_NAME, implementations can " +
"extend 'CatalogExtension'.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-29412, commit ID: 9407fba0375675d6ee6461253f3b8230e8d67509#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388856145
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2485,14 +2486,14 @@ object SQLConf {
.doc("When set to true, java.text.SimpleDateFormat is used for formatting and parsing " +
"dates/timestamps in a locale-sensitive manner. When set to false, classes from " +
"java.time.* packages are used for the same purpose.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-30668, commit ID: 92f57237871400ab9d499e1174af22a867c01988#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388762805
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1927,7 +1927,7 @@ object SQLConf {
.internal()
.doc("The size (measured in number of rows) of the queue used in continuous execution to" +
" buffer the results of a ContinuousDataReader.")
- .version("")
+ .version("2.3.0")
Review comment:
SPARK-22789, commit ID: 8941a4abcada873c26af924e129173dc33d66d71#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388764348
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2065,7 +2065,7 @@ object SQLConf {
"satisfying a query. Note that this optimization doesn't prune nested fields from " +
"physical data source scanning. For pruning nested fields from scanning, please use " +
"`spark.sql.optimizer.nestedSchemaPruning.enabled` config.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-27707, commit ID: 127bc899ae78d73332a87f0972b5db3c9936c1f1#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388769134
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2239,7 +2239,7 @@ object SQLConf {
.internal()
.doc("When set to true, the parser of JSON data source treats empty strings as null for " +
"some data types such as `IntegerType`.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-25040, commit ID: d3de7568f32e298442f07b0a28b2c906de72c797#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388768202
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2194,7 +2194,7 @@ object SQLConf {
.doc("When set to true, negative scale of Decimal type is allowed. For example, " +
"the type of number 1E10BD under legacy mode is DecimalType(2, -9), but is " +
"Decimal(11, 0) in non legacy mode.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-30812, commit ID: b76bc0b1b8b2abd00a84f805af90ca4c5925faaa#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388854914
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2419,7 +2420,7 @@ object SQLConf {
.doc("A comma-delimited string config of the optional additional remote Maven mirror " +
"repositories. This is only used for downloading Hive jars in IsolatedClientLoader " +
"if the default Maven Central repo is unreachable.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-29175, commit ID: 3d7359ad4202067b26a199657b6a3e1f38be0e4d#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-595652802
**[Test build #119452 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119452/testReport)** for PR 27829 at commit [`f8ea7e0`](https://github.com/apache/spark/commit/f8ea7e04435510242751b28765b50e1076108833).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-596190797
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388767770
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2175,7 +2175,7 @@ object SQLConf {
"set operations are performed from left to right as they appear in the query. When set " +
"to false and order of evaluation is not specified by parentheses, INTERSECT operations " +
"are performed before any UNION, EXCEPT and MINUS operations.")
- .version("")
+ .version("2.4.0")
Review comment:
SPARK-24966, commit ID: 73dd6cf9b558f9d752e1f3c13584344257ad7863#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388764031
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2044,7 +2044,7 @@ object SQLConf {
"satisfying a query. This optimization allows columnar file format readers to avoid " +
"reading unnecessary nested column data. Currently Parquet and ORC are the " +
"data sources that implement this optimization.")
- .version("")
+ .version("2.4.1")
Review comment:
SPARK-4502, commit ID: dfcff38394929970fee454c69864d0e10d59f8d4#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388763888
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2033,7 +2033,7 @@ object SQLConf {
"issues. Turn on this config to insert a local sort before actually doing repartition " +
"to generate consistent repartition results. The performance of repartition() may go " +
"down since we insert extra local sort before it.")
- .version("")
+ .version("2.1.4")
Review comment:
SPARK-23207 and SPARK-22905 and SPARK-24564 and SPARK-25114, commit ID: 4d2d3d47e00e78893b1ecd5a9a9070adc5243ac9#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388854366
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2388,7 +2388,7 @@ object SQLConf {
"CORRECTED, inner CTE definitions take precedence. The default value is EXCEPTION, " +
"AnalysisException is thrown while name conflict is detected in nested CTE. This config " +
"will be removed in future versions and CORRECTED will be the only behavior.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-30829, commit ID: 00943be81afbca6be13e1e72b24536cd98a788d6#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-595763377
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388767941
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2184,7 +2184,7 @@ object SQLConf {
.internal()
.doc("When set to true, a literal with an exponent (e.g. 1E-30) would be parsed " +
"as Decimal rather than Double.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-29956, commit ID: 87ebfaf003fcd05a7f6d23b3ecd4661409ce5f2f#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-595652802
**[Test build #119452 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119452/testReport)** for PR 27829 at commit [`f8ea7e0`](https://github.com/apache/spark/commit/f8ea7e04435510242751b28765b50e1076108833).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388768788
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2221,7 +2221,7 @@ object SQLConf {
.internal()
.doc("When true, the bucketed table scan will list files during planning to figure out the " +
"output ordering, which is expensive and may make the planning quite slow.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-28595, commit ID: 469423f33887a966aaa33eb75f5e7974a0a97beb#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388769494
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2258,7 +2258,7 @@ object SQLConf {
.internal()
.doc("When set to true, user is allowed to use org.apache.spark.sql.functions." +
"udf(f: AnyRef, dataType: DataType). Otherwise, exception will be throw.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-26580, commit ID: bc30a07ce262840c99a752db4fbd3a423f652017#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388763074
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1945,14 +1945,14 @@ object SQLConf {
.doc("A comma-separated list of data source short names or fully qualified data source " +
"implementation class names for which Data Source V2 code path is disabled. These data " +
"sources will fallback to Data Source V1 code path.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-28747, commit ID: cb06209fc908bac6ce6a8f20653865489773cbc3#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388769856
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2277,15 +2277,15 @@ object SQLConf {
.doc("When set to true, the key attribute resulted from running `Dataset.groupByKey` " +
"for non-struct key type, will be named as `value`, following the behavior of Spark " +
"version 2.4 and earlier.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-26085, commit ID: ab2eafb3cdc7631452650c6cac03a92629255347#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388854578
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2401,6 +2401,7 @@ object SQLConf {
"When set to CORRECTED, classes from java.time.* packages are used for the same purpose. " +
"The default value is EXCEPTION, RuntimeException is thrown when we will get different " +
"results.")
+ .version("3.1.0")
Review comment:
SPARK-30668, commit ID: 7db0af578585ecaeee9fd23f8189292289b52a97#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388785485
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2333,14 +2333,14 @@ object SQLConf {
.internal()
.doc("If it is set to true, date/timestamp will cast to string in binary comparisons " +
"with String")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-27638, commit ID: 83d289eef492de8c7f3e5145f9bd75431608b500#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-595653345
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-610346800
Merged to branch-3.0 too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-595763377
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388855576
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2451,21 +2452,21 @@ object SQLConf {
.internal()
.doc("When true, only a single file can be added using ADD FILE. If false, then users " +
"can add directory by passing directory path to ADD FILE.")
- .version("")
+ .version("3.0.0")
.booleanConf
.createWithDefault(false)
val LEGACY_MSSQLSERVER_NUMERIC_MAPPING_ENABLED =
buildConf("spark.sql.legacy.mssqlserver.numericMapping.enabled")
.internal()
.doc("When true, use legacy MySqlServer SMALLINT and REAL type mapping.")
- .version("")
+ .version("2.4.5")
Review comment:
SPARK-28152, commit ID: 69de7f31c37a7e0298e66cc814afc1b0aa948bbb#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388785647
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2333,14 +2333,14 @@ object SQLConf {
.internal()
.doc("If it is set to true, date/timestamp will cast to string in binary comparisons " +
"with String")
- .version("")
+ .version("3.0.0")
.booleanConf
.createWithDefault(false)
val DEFAULT_CATALOG = buildConf("spark.sql.defaultCatalog")
.doc("Name of the default catalog. This will be the current catalog if users have not " +
"explicitly set the current catalog yet.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-29753, commit ID: 942753a44beeae5f0142ceefa307e90cbc1234c5#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388764911
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2111,14 +2111,14 @@ object SQLConf {
s"effect when ${REPL_EAGER_EVAL_ENABLED.key} is set to true. The valid range of this " +
"config is from 0 to (Int.MaxValue - 1), so the invalid config like negative and " +
"greater than (Int.MaxValue - 1) will be normalized to 0 and (Int.MaxValue - 1).")
- .version("")
+ .version("2.4.0")
Review comment:
SPARK-24215, commit ID: 6a0b77a55d53e74ac0a0892556c3a7a933474948#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388856037
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2475,7 +2476,7 @@ object SQLConf {
.doc("The number of partitions to be handled in one turn when use " +
"`AlterTableAddPartitionCommand` to add partitions into table. The smaller " +
"batch size is, the less memory is required for the real handler, e.g. Hive Metastore.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-29938, commit ID: 5ccbb38a71890b114c707279e7395d1f6284ebfd#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388855728
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2451,21 +2452,21 @@ object SQLConf {
.internal()
.doc("When true, only a single file can be added using ADD FILE. If false, then users " +
"can add directory by passing directory path to ADD FILE.")
- .version("")
+ .version("3.0.0")
.booleanConf
.createWithDefault(false)
val LEGACY_MSSQLSERVER_NUMERIC_MAPPING_ENABLED =
buildConf("spark.sql.legacy.mssqlserver.numericMapping.enabled")
.internal()
.doc("When true, use legacy MySqlServer SMALLINT and REAL type mapping.")
- .version("")
+ .version("2.4.5")
.booleanConf
.createWithDefault(false)
val CSV_FILTER_PUSHDOWN_ENABLED = buildConf("spark.sql.csv.filterPushdown.enabled")
.doc("When true, enable filter pushdown to CSV datasource.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-30323, commit ID: 4e50f0291f032b4a5c0b46ed01fdef14e4cbb050#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388763210
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1945,14 +1945,14 @@ object SQLConf {
.doc("A comma-separated list of data source short names or fully qualified data source " +
"implementation class names for which Data Source V2 code path is disabled. These data " +
"sources will fallback to Data Source V1 code path.")
- .version("")
+ .version("3.0.0")
.stringConf
.createWithDefault("avro,csv,json,kafka,orc,parquet,text")
val DISABLED_V2_STREAMING_WRITERS = buildConf("spark.sql.streaming.disabledV2Writers")
.doc("A comma-separated list of fully qualified data source register class names for which" +
" StreamWriteSupport is disabled. Writes to these sources will fall back to the V1 Sinks.")
- .version("")
+ .version("2.3.1")
Review comment:
SPARK-23196, commit ID: 588b9694c1967ff45774431441e84081ee6eb515#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388855232
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2442,7 +2443,7 @@ object SQLConf {
.doc("When true, all database and table properties are not reserved and available for " +
"create/alter syntaxes. But please be aware that the reserved properties will be " +
"silently removed.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-30812, commit ID: b76bc0b1b8b2abd00a84f805af90ca4c5925faaa#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388761859
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1876,7 +1876,7 @@ object SQLConf {
"information. The values of options whose names that match this regex will be redacted " +
"in the explain output. This redaction is applied on top of the global redaction " +
s"configuration defined by ${SECRET_REDACTION_PATTERN.key}.")
- .version("")
+ .version("2.2.2")
Review comment:
SPARK-23850, commit ID: 6a55d8b03053e616dcacb79cd2c29a06d219dc32#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388764446
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2075,7 +2075,7 @@ object SQLConf {
.doc("In SQL queries with a SORT followed by a LIMIT like " +
"'SELECT x FROM t ORDER BY y LIMIT m', if m is under this threshold, do a top-K sort" +
" in memory, otherwise do a global sort which spills to disk if necessary.")
- .version("")
+ .version("2.4.0")
Review comment:
SPARK-24193, commit ID: 8a837bf4f3f2758f7825d2362cf9de209026651a#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388762305
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1886,20 +1886,20 @@ object SQLConf {
"information. When this regex matches a string part, that string part is replaced by a " +
"dummy value. This is currently used to redact the output of SQL explain commands. " +
"When this conf is not set, the value from `spark.redaction.string.regex` is used.")
- .version("")
+ .version("2.3.0")
.fallbackConf(org.apache.spark.internal.config.STRING_REDACTION_PATTERN)
val CONCAT_BINARY_AS_STRING = buildConf("spark.sql.function.concatBinaryAsString")
.doc("When this option is set to false and all inputs are binary, `functions.concat` returns " +
"an output as binary. Otherwise, it returns as a string.")
- .version("")
+ .version("2.3.0")
.booleanConf
.createWithDefault(false)
val ELT_OUTPUT_AS_STRING = buildConf("spark.sql.function.eltOutputAsString")
.doc("When this option is set to false and all inputs are binary, `elt` returns " +
"an output as binary. Otherwise, it returns as a string.")
- .version("")
+ .version("2.3.0")
Review comment:
SPARK-22937, commit ID: bf853018cabcd3b3abf84bfe534d2981020b4a71#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388763443
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1984,7 +1984,7 @@ object SQLConf {
"(which takes precedence over this setting), e.g. " +
"dataframe.write.option(\"partitionOverwriteMode\", \"dynamic\").save(path)."
)
- .version("")
+ .version("2.3.0")
Review comment:
SPARK-20236, commit ID: b96248862589bae1ddcdb14ce4c802789a001306#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388763749
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2020,7 +2020,7 @@ object SQLConf {
"throw a runtime exception if an overflow occurs in any operation on integral/decimal " +
"field. 2. Spark will forbid using the reserved keywords of ANSI SQL as identifiers in " +
"the SQL parser.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-30125, commit ID: d9b30694122f8716d3acb448638ef1e2b96ebc7a#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388763585
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2009,7 +2009,7 @@ object SQLConf {
"in type coercion, e.g. converting `double` to `int` or `decimal` to `double` is " +
"not allowed."
)
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-28730, commit ID: 895c90b582cc2b2667241f66d5b733852aeef9eb#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388769291
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2249,7 +2249,7 @@ object SQLConf {
.doc("When set to true, Spark returns an empty collection with `StringType` as element " +
"type if the `array`/`map` function is called without any parameters. Otherwise, Spark " +
"returns an empty collection with `NullType` as element type.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-30790, commit ID: 8ab6ae3ede96adb093347470a5cbbf17fe8c04e9#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388762160
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1886,20 +1886,20 @@ object SQLConf {
"information. When this regex matches a string part, that string part is replaced by a " +
"dummy value. This is currently used to redact the output of SQL explain commands. " +
"When this conf is not set, the value from `spark.redaction.string.regex` is used.")
- .version("")
+ .version("2.3.0")
.fallbackConf(org.apache.spark.internal.config.STRING_REDACTION_PATTERN)
val CONCAT_BINARY_AS_STRING = buildConf("spark.sql.function.concatBinaryAsString")
.doc("When this option is set to false and all inputs are binary, `functions.concat` returns " +
"an output as binary. Otherwise, it returns as a string.")
- .version("")
+ .version("2.3.0")
Review comment:
SPARK-22771, commit ID: f2b3525c17d660cf6f082bbafea8632615b4f58e#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-595762401
**[Test build #119452 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119452/testReport)** for PR 27829 at commit [`f8ea7e0`](https://github.com/apache/spark/commit/f8ea7e04435510242751b28765b50e1076108833).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388855431
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2451,21 +2452,21 @@ object SQLConf {
.internal()
.doc("When true, only a single file can be added using ADD FILE. If false, then users " +
"can add directory by passing directory path to ADD FILE.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-30234, commit ID: 8a8d1fbb10af6da481f26831cd519ef46ccbce6c#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-595653357
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24187/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388767390
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2155,7 +2155,7 @@ object SQLConf {
.internal()
.doc("If it is set to true, size of null returns -1. This behavior was inherited from Hive. " +
"The size function returns null for null input if the flag is disabled.")
- .version("")
+ .version("2.4.0")
Review comment:
SPARK-24605, commit ID: d08f53dc61f662f5291f71bcbe1a7b9f531a34d2#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388763334
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1963,7 +1963,7 @@ object SQLConf {
"A comma-separated list of fully qualified data source register class names for which " +
"MicroBatchReadSupport is disabled. Reads from these sources will fall back to the " +
"V1 Sources.")
- .version("")
+ .version("2.4.0")
Review comment:
SPARK-23362, commit ID: 0a73aa31f41c83503d5d99eff3c9d7b406014ab3#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388765047
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2111,14 +2111,14 @@ object SQLConf {
s"effect when ${REPL_EAGER_EVAL_ENABLED.key} is set to true. The valid range of this " +
"config is from 0 to (Int.MaxValue - 1), so the invalid config like negative and " +
"greater than (Int.MaxValue - 1) will be normalized to 0 and (Int.MaxValue - 1).")
- .version("")
+ .version("2.4.0")
.intConf
.createWithDefault(20)
val REPL_EAGER_EVAL_TRUNCATE = buildConf("spark.sql.repl.eagerEval.truncate")
.doc("The max number of characters for each cell that is returned by eager evaluation. " +
s"This only takes effect when ${REPL_EAGER_EVAL_ENABLED.key} is set to true.")
- .version("")
+ .version("2.4.0")
Review comment:
SPARK-24215, commit ID: 6a0b77a55d53e74ac0a0892556c3a7a933474948#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-595653357
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24187/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388770676
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2315,15 +2315,15 @@ object SQLConf {
"java.time.LocalDate classes of Java 8 API are used as external types for " +
"Catalyst's TimestampType and DateType. If it is set to false, java.sql.Timestamp " +
"and java.sql.Date are used for the same purpose.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-27008, commit ID: 52671d631d2a64ed1cfa0c6e01168908faf92df8#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388768973
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2230,7 +2230,7 @@ object SQLConf {
.internal()
.doc("If it is set to true, the parser will treat HAVING without GROUP BY as a normal " +
"WHERE, which does not follow SQL standard.")
- .version("")
+ .version("2.4.1")
Review comment:
SPARK-25708, commit ID: 3dba5d41f1a66ae5eb08404d103284110c45a351#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-595653345
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388768392
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2203,15 +2203,15 @@ object SQLConf {
.internal()
.doc("When set to true, CREATE TABLE syntax without a provider will use hive " +
s"instead of the value of ${DEFAULT_DATA_SOURCE_NAME.key}.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-30098, commit ID: 58be82ad4b98fc17e821e916e69e77a6aa36209d#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388762651
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1910,15 +1910,15 @@ object SQLConf {
"user-specified schema. If the validation fails, a runtime exception is thrown. " +
"When this option is set to false, the partition column value will be converted to null " +
"if it can not be casted to corresponding user-specified schema.")
- .version("")
+ .version("3.0.0")
.booleanConf
.createWithDefault(true)
val CONTINUOUS_STREAMING_EPOCH_BACKLOG_QUEUE_SIZE =
buildConf("spark.sql.streaming.continuous.epochBacklogQueueSize")
.doc("The max number of entries to be stored in queue to wait for late epochs. " +
"If this parameter is exceeded by the size of the queue, stream will stop with an error.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-24063, commit ID: c4bbfd177b4e7cb46f47b39df9fd71d2d9a12c6d#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388770845
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2315,15 +2315,15 @@ object SQLConf {
"java.time.LocalDate classes of Java 8 API are used as external types for " +
"Catalyst's TimestampType and DateType. If it is set to false, java.sql.Timestamp " +
"and java.sql.Date are used for the same purpose.")
- .version("")
+ .version("3.0.0")
.booleanConf
.createWithDefault(false)
val SOURCES_BINARY_FILE_MAX_LENGTH = buildConf("spark.sql.sources.binaryFile.maxLength")
.doc("The max length of a file that can be read by the binary file data source. " +
"Spark will fail fast and not attempt to read the file if its length exceeds this value. " +
"The theoretical max is Int.MaxValue, though VMs might implement a smaller max.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-27588, commit ID: 618d6bff71073c8c93501ab7392c3cc579730f0b#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388769675
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2267,7 +2267,7 @@ object SQLConf {
.internal()
.doc("When set to true, TRUNCATE TABLE command will not try to set back original " +
"permission and ACLs when re-creating the table/partition paths.")
- .version("")
+ .version("2.4.6")
Review comment:
SPARK-30312, commit ID: 830a4ec59b86253f18eb7dfd6ed0bbe0d7920e5b#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388764575
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2091,7 +2091,7 @@ object SQLConf {
.internal()
.doc("If it is set to true, column names of the requested schema are passed to CSV parser. " +
"Other column values can be ignored during parsing even if they are malformed.")
- .version("")
+ .version("2.4.0")
Review comment:
SPARK-24244 and SPARK-24368, commit ID: 64fad0b519cf35b8c0a0dec18dd3df9488a5ed25#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-595763392
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119452/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388768577
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2203,15 +2203,15 @@ object SQLConf {
.internal()
.doc("When set to true, CREATE TABLE syntax without a provider will use hive " +
s"instead of the value of ${DEFAULT_DATA_SOURCE_NAME.key}.")
- .version("")
+ .version("3.0.0")
.booleanConf
.createWithDefault(false)
val LEGACY_INTEGRALDIVIDE_RETURN_LONG = buildConf("spark.sql.legacy.integralDivide.returnBigint")
.doc("If it is set to true, the div operator returns always a bigint. This behavior was " +
"inherited from Hive. Otherwise, the return type is the data type of the operands.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-25457, commit ID: 47d6e80a2e64823fabb596503fb6a6cc6f51f713#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388767075
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2129,15 +2129,15 @@ object SQLConf {
"by the fast hash aggregate product operator. The bit is not for actual value, " +
"but the actual numBuckets is determined by loadFactor " +
"(e.g: default bit value 16 , the actual numBuckets is ((1 << 16) / 0.5).")
- .version("")
+ .version("2.4.0")
.intConf
.checkValue(bit => bit >= 10 && bit <= 30, "The bit value must be in [10, 30].")
.createWithDefault(16)
val AVRO_COMPRESSION_CODEC = buildConf("spark.sql.avro.compression.codec")
.doc("Compression codec used in writing of AVRO files. Supported codecs: " +
"uncompressed, deflate, snappy, bzip2 and xz. Default codec is snappy.")
- .version("")
+ .version("2.4.0")
Review comment:
SPARK-24881, commit ID: 0a0f68bae6c0a1bf30184b1e9ac6bf3805bd7511#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-596172071
@HyukjinKwon @MaxGekk Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388856277
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2485,14 +2486,14 @@ object SQLConf {
.doc("When set to true, java.text.SimpleDateFormat is used for formatting and parsing " +
"dates/timestamps in a locale-sensitive manner. When set to false, classes from " +
"java.time.* packages are used for the same purpose.")
- .version("")
+ .version("3.0.0")
.booleanConf
.createWithDefault(false)
val LEGACY_ALLOW_HASH_ON_MAPTYPE = buildConf("spark.sql.legacy.allowHashOnMapType")
.doc("When set to true, hash expressions can be applied on elements of MapType. Otherwise, " +
"an analysis exception will be thrown.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-25829, commit ID: 33329caa81827a245b84158b13234b88a4746e56#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388770491
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2306,7 +2306,7 @@ object SQLConf {
.internal()
.doc("If it is set to true, SET command will fail when the key is registered as " +
"a SparkConf entry.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-26060, commit ID: 1ab3d3e474ce2e36d58aea8ad09fb61f0c73e5c5#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388855071
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2432,7 +2433,7 @@ object SQLConf {
"all interval units out of the specified range. If it is set to `false`, " +
"`ParseException` is thrown if the input does not match to the pattern " +
"defined by `from` and `to`.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-29864 and SPARK-29920, commit ID: e933539cdd557297daf97ff5e532a3f098896979#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388770013
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2277,15 +2277,15 @@ object SQLConf {
.doc("When set to true, the key attribute resulted from running `Dataset.groupByKey` " +
"for non-struct key type, will be named as `value`, following the behavior of Spark " +
"version 2.4 and earlier.")
- .version("")
+ .version("3.0.0")
.booleanConf
.createWithDefault(false)
val MAX_TO_STRING_FIELDS = buildConf("spark.sql.debug.maxToStringFields")
.doc("Maximum number of fields of sequence-like entries can be converted to strings " +
"in debug output. Any elements beyond the limit will be dropped and replaced by a" +
""" "... N more fields" placeholder.""")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-26066, commit ID: 81550b38e43fb20f89f529d2127575c71a54a538#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388854731
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2410,7 +2411,7 @@ object SQLConf {
buildConf("spark.sql.legacy.followThreeValuedLogicInArrayExists")
.internal()
.doc("When true, the ArrayExists will follow the three-valued boolean logic.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-30812, commit ID: b76bc0b1b8b2abd00a84f805af90ca4c5925faaa#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388764191
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2054,7 +2054,7 @@ object SQLConf {
.doc("Prune nested fields from object serialization operator which are unnecessary in " +
"satisfying a query. This optimization allows object serializers to avoid " +
"executing unnecessary nested expressions.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-26837, commit ID: 0f2c0b53e8fb18c86c67b5dd679c006db93f94a5#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#issuecomment-595763392
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119452/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388765223
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2129,15 +2129,15 @@ object SQLConf {
"by the fast hash aggregate product operator. The bit is not for actual value, " +
"but the actual numBuckets is determined by loadFactor " +
"(e.g: default bit value 16 , the actual numBuckets is ((1 << 16) / 0.5).")
- .version("")
+ .version("2.4.0")
Review comment:
SPARK-24978, commit ID: 6193a202aab0271b4532ee4b740318290f2c44a1#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27829:
[SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the
configuration of SQL
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27829: [SPARK-30841][SQL][DOC][FOLLOW-UP] Add version information to the configuration of SQL
URL: https://github.com/apache/spark/pull/27829#discussion_r388855728
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2451,21 +2452,21 @@ object SQLConf {
.internal()
.doc("When true, only a single file can be added using ADD FILE. If false, then users " +
"can add directory by passing directory path to ADD FILE.")
- .version("")
+ .version("3.0.0")
.booleanConf
.createWithDefault(false)
val LEGACY_MSSQLSERVER_NUMERIC_MAPPING_ENABLED =
buildConf("spark.sql.legacy.mssqlserver.numericMapping.enabled")
.internal()
.doc("When true, use legacy MySqlServer SMALLINT and REAL type mapping.")
- .version("")
+ .version("2.4.5")
.booleanConf
.createWithDefault(false)
val CSV_FILTER_PUSHDOWN_ENABLED = buildConf("spark.sql.csv.filterPushdown.enabled")
.doc("When true, enable filter pushdown to CSV datasource.")
- .version("")
+ .version("3.0.0")
Review comment:
SPARK-30323, 4e50f0291f032b4a5c0b46ed01fdef14e4cbb050#diff-9a6b543db706f1a90f790783d6930a13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org