You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/06/10 00:38:46 UTC
[kudu-CR] fs manager: clean tmp files from all special directories
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7144
to review the following change.
Change subject: fs_manager: clean tmp files from all special directories
......................................................................
fs_manager: clean tmp files from all special directories
Commit c26e09e regressed tmp file cleanup in that the tablet-meta and cmeta
directories were no longer cleaned. This is because I assumed that the
cleanup done in DataDirManager::Open would include these directories (they
are typically found in the first data root), but I forgot that in the
DataDirManager, a data directory is the data root plus a "/data" suffix.
This patch fixes that by explicitly including all "special" directories in
the FsManager's cleanup routine.
Change-Id: Ia6340ad72a6996869e7a83d0d66c165dfe2173c8
---
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
2 files changed, 11 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/7144/1
--
To view, visit http://gerrit.cloudera.org:8080/7144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6340ad72a6996869e7a83d0d66c165dfe2173c8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fs manager: clean tmp files from all special directories
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: fs_manager: clean tmp files from all special directories
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6340ad72a6996869e7a83d0d66c165dfe2173c8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] fs manager: clean tmp files from all special directories
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: fs_manager: clean tmp files from all special directories
......................................................................
Patch Set 1: Code-Review+2
lgtm, did you verify this?
--
To view, visit http://gerrit.cloudera.org:8080/7144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6340ad72a6996869e7a83d0d66c165dfe2173c8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] fs manager: clean tmp files from all special directories
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: fs_manager: clean tmp files from all special directories
......................................................................
Patch Set 1:
> lgtm, did you verify this?
I was lazy. Sorry. New version has an updated test which fails without this patch.
--
To view, visit http://gerrit.cloudera.org:8080/7144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6340ad72a6996869e7a83d0d66c165dfe2173c8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] fs manager: clean tmp files from all special directories
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: fs_manager: clean tmp files from all special directories
......................................................................
fs_manager: clean tmp files from all special directories
Commit c26e09e regressed tmp file cleanup in that the tablet-meta and cmeta
directories were no longer cleaned. This is because I assumed that the
cleanup done in DataDirManager::Open would include these directories (they
are typically found in the first data root), but I forgot that in the
DataDirManager, a data directory is the data root plus a "/data" suffix.
This patch fixes that by explicitly including all "special" directories in
the FsManager's cleanup routine.
Change-Id: Ia6340ad72a6996869e7a83d0d66c165dfe2173c8
Reviewed-on: http://gerrit.cloudera.org:8080/7144
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
3 files changed, 21 insertions(+), 8 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6340ad72a6996869e7a83d0d66c165dfe2173c8
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fs manager: clean tmp files from all special directories
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7144
to look at the new patch set (#2).
Change subject: fs_manager: clean tmp files from all special directories
......................................................................
fs_manager: clean tmp files from all special directories
Commit c26e09e regressed tmp file cleanup in that the tablet-meta and cmeta
directories were no longer cleaned. This is because I assumed that the
cleanup done in DataDirManager::Open would include these directories (they
are typically found in the first data root), but I forgot that in the
DataDirManager, a data directory is the data root plus a "/data" suffix.
This patch fixes that by explicitly including all "special" directories in
the FsManager's cleanup routine.
Change-Id: Ia6340ad72a6996869e7a83d0d66c165dfe2173c8
---
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
3 files changed, 21 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/7144/2
--
To view, visit http://gerrit.cloudera.org:8080/7144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia6340ad72a6996869e7a83d0d66c165dfe2173c8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>