You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/16 07:10:10 UTC
[GitHub] [iceberg] nastra opened a new pull request #2834: Nessie: Rename auth_type to auth-type
nastra opened a new pull request #2834:
URL: https://github.com/apache/iceberg/pull/2834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rymurr merged pull request #2834: Nessie: Bump Nessie to 0.8.3 / Rename auth_type to auth-type
Posted by GitBox <gi...@apache.org>.
rymurr merged pull request #2834:
URL: https://github.com/apache/iceberg/pull/2834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #2834: Nessie: Rename auth_type to auth-type
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #2834:
URL: https://github.com/apache/iceberg/pull/2834#discussion_r671480914
##########
File path: nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java
##########
@@ -108,7 +108,7 @@ NessieCatalog initCatalog(String ref) {
newCatalog.setConf(hadoopConfig);
newCatalog.initialize("nessie", ImmutableMap.of("ref", ref,
CatalogProperties.URI, uri,
- "auth_type", "NONE",
+ "auth-type", "NONE",
Review comment:
Is this a constant used in the Nessie project itself? If so, perhaps you might consider a follow up for adding `NessieCatalogProperties` class at some point, to help make them more clear to users looking to adopt Nessie coming from the Iceberg repo itself 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a change in pull request #2834: Nessie: Bump Nessie to 0.8.3 / Rename auth_type to auth-type
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #2834:
URL: https://github.com/apache/iceberg/pull/2834#discussion_r672853068
##########
File path: nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java
##########
@@ -108,7 +108,7 @@ NessieCatalog initCatalog(String ref) {
newCatalog.setConf(hadoopConfig);
newCatalog.initialize("nessie", ImmutableMap.of("ref", ref,
CatalogProperties.URI, uri,
- "auth_type", "NONE",
+ "auth-type", "NONE",
Review comment:
yep will consider this for a future follow up, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rymurr merged pull request #2834: Nessie: Bump Nessie to 0.8.3 / Rename auth_type to auth-type
Posted by GitBox <gi...@apache.org>.
rymurr merged pull request #2834:
URL: https://github.com/apache/iceberg/pull/2834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a change in pull request #2834: Nessie: Bump Nessie to 0.8.3 / Rename auth_type to auth-type
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #2834:
URL: https://github.com/apache/iceberg/pull/2834#discussion_r672853068
##########
File path: nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java
##########
@@ -108,7 +108,7 @@ NessieCatalog initCatalog(String ref) {
newCatalog.setConf(hadoopConfig);
newCatalog.initialize("nessie", ImmutableMap.of("ref", ref,
CatalogProperties.URI, uri,
- "auth_type", "NONE",
+ "auth-type", "NONE",
Review comment:
yep will consider this for a future follow up, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a change in pull request #2834: Nessie: Bump Nessie to 0.8.3 / Rename auth_type to auth-type
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #2834:
URL: https://github.com/apache/iceberg/pull/2834#discussion_r672853068
##########
File path: nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java
##########
@@ -108,7 +108,7 @@ NessieCatalog initCatalog(String ref) {
newCatalog.setConf(hadoopConfig);
newCatalog.initialize("nessie", ImmutableMap.of("ref", ref,
CatalogProperties.URI, uri,
- "auth_type", "NONE",
+ "auth-type", "NONE",
Review comment:
yep will consider this for a future follow up, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rymurr merged pull request #2834: Nessie: Bump Nessie to 0.8.3 / Rename auth_type to auth-type
Posted by GitBox <gi...@apache.org>.
rymurr merged pull request #2834:
URL: https://github.com/apache/iceberg/pull/2834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org