You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/02/18 08:06:33 UTC
[GitHub] [calcite-avatica] asolimando commented on a change in pull request #138: [CALCITE-2489] Order of fields in JavaTypeFactoryImpl#createStructTyp…
asolimando commented on a change in pull request #138:
URL: https://github.com/apache/calcite-avatica/pull/138#discussion_r578206373
##########
File path: core/src/main/java/org/apache/calcite/avatica/Meta.java
##########
@@ -647,11 +648,12 @@ public static CursorFactory create(@JsonProperty("style") Style style,
public static final CursorFactory LIST =
new CursorFactory(Style.LIST, null, null, null);
- public static CursorFactory record(Class resultClazz) {
- return new CursorFactory(Style.RECORD, resultClazz, null, null);
+ public static CursorFactory record(Class resultClass, List<Field> fields,
+ List<String> fieldNames) {
+ return record(Style.RECORD_PROJECTION, resultClass, fields, fieldNames);
Review comment:
It's done, sorry to have missed that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org