You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/23 13:40:52 UTC
[GitHub] [iceberg] snazy opened a new pull request #4207: Cancel duplicate workflow runs
snazy opened a new pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207
Take 2, using GitHub's native functionality.
Basically reverts #3004.
See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207#issuecomment-1061296053
Thanks for fixing this, @snazy!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] snazy commented on a change in pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
snazy commented on a change in pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207#discussion_r814648421
##########
File path: .github/workflows/flink-ci.yml
##########
@@ -59,6 +59,10 @@ on:
- 'README.md'
- 'CONTRIBUTING.md'
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}
Review comment:
Yea, no event without a name (I hope so ;) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick edited a comment on pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
kbendick edited a comment on pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207#issuecomment-1049019055
Ahhh I see the docs have been updated and this concurrency group is explicitly called out: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-only-cancel-in-progress-jobs-or-runs-for-the-current-workflow
My (very limited) experience was that it would cancel any workflow (outside of the current PR or not), but I guess if you have `github.ref` then that should be ok. `github.ref` didn't exist at the time iirc.
This looks to cover all of the workflows that were part of the old cancel-duplicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] snazy commented on pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
snazy commented on pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207#issuecomment-1049091350
We've merged the same change into Nessie today and I realized that Quarkus is also using this technique now - they have more complex conditions though: https://github.com/quarkusio/quarkus/blob/main/.github/workflows/ci-actions-incremental.yml#L36-L38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207#discussion_r814307084
##########
File path: .github/workflows/flink-ci.yml
##########
@@ -59,6 +59,10 @@ on:
- 'README.md'
- 'CONTRIBUTING.md'
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}
Review comment:
Good call 👍 .
Maybe I would add a default value of `${{ github.event_name == 'pull_request' || false }}`. But I don't think that's needed because `event_name` should be defined for all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207#issuecomment-1049019055
Ahhh I see the docs have been updated: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-only-cancel-in-progress-jobs-or-runs-for-the-current-workflow
My (very limited) experience was that it would cancel any workflow (outside of the current PR or not), but I guess if you have `github.ref` then that should be ok.
This has a cautious +1 from me, but if you've used this elsewhere then I definitely trust you. This looks to cover all of the workflows that were part of the old cancel-duplicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207#discussion_r814307084
##########
File path: .github/workflows/flink-ci.yml
##########
@@ -59,6 +59,10 @@ on:
- 'README.md'
- 'CONTRIBUTING.md'
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: ${{ github.event_name == 'pull_request' }}
Review comment:
Good call 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] snazy edited a comment on pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
snazy edited a comment on pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207#issuecomment-1049529158
Realized that the proposed change would cancel previous CI runs on the master branch as well, which is rather not so good. So I've pushed another commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] snazy commented on pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
snazy commented on pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207#issuecomment-1048794875
/cc @kbendick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick edited a comment on pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
kbendick edited a comment on pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207#issuecomment-1049019055
Ahhh I see the docs have been updated: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-only-cancel-in-progress-jobs-or-runs-for-the-current-workflow
My (very limited) experience was that it would cancel any workflow (outside of the current PR or not), but I guess if you have `github.ref` then that should be ok. `github.ref` didn't exist at the time iirc.
This looks to cover all of the workflows that were part of the old cancel-duplicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207#issuecomment-1049073160
Looking at this Stack Overflow post, I'm much more confident in this now: https://stackoverflow.com/questions/58033366/how-to-get-the-current-branch-within-github-actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] snazy commented on pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
snazy commented on pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207#issuecomment-1049529158
Realized that the proposed change would cancel previous CI runs on the master branch as well, which is rather not so good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4207: Cancel duplicate workflow runs
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #4207:
URL: https://github.com/apache/iceberg/pull/4207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org