[GitHub] garrensmith commented on a change in pull request #1001: Fix table mode to show boolean values

[GitBox <gi...@apache.org>]

garrensmith commented on a change in pull request #1001: Fix table mode to show boolean values
URL: https://github.com/apache/couchdb-fauxton/pull/1001#discussion_r146213138
 
 

 ##########
 File path: app/addons/documents/index-results/components/results/TableRow.js
 ##########
 @@ -37,7 +37,8 @@ export default class TableRow extends React.Component {
     const row = this.props.data.selectedFields.map(function (k, i) {
 
       const key = 'tableview-data-cell-' + rowNumber + k + i + el[k];
-      const stringified = typeof el[k] === 'object' ? JSON.stringify(el[k], null, '  ') : el[k];
 
 Review comment:
   This looks good. Can you write a test that proves this works and so we don't ever have a regression on this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services