You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/08 23:14:31 UTC

[GitHub] [druid] vogievetsky opened a new issue #10369: Using `LIMIT 0` in SQL SELECT query causes `sqlOuterLimit` to be ignored

vogievetsky opened a new issue #10369:
URL: https://github.com/apache/druid/issues/10369


   ### Affected Version
   
   The Druid version 0.19.0, 0.18.0
   
   ### Description
   
   When issuing a `SELECT` (no `GROUP BY`) query with `LIMIT 0` the `sqlOuterLimit: 100` context value is ignored and all rows are returned.
   
   Good:
   
   ![image](https://user-images.githubusercontent.com/177816/92535949-46777b00-f1ed-11ea-96a6-a93f8fb9aa91.png)
   
   Bad:
   
   ![image](https://user-images.githubusercontent.com/177816/92535998-6a3ac100-f1ed-11ea-8f42-848d6b4b8a1e.png)
   
   Another simpler example:
   
   ```sql
   SELECT * FROM (
     SELECT * FROM "wikipedia" LIMIT 200
   ) LIMIT 0
   ```
   
   ![image](https://user-images.githubusercontent.com/177816/92536191-dfa69180-f1ed-11ea-9def-a3082f1dbc76.png)
   
   Side note: setting `LIMIT 0` on a GROUP BY query results in 'could not build plan' which is fair enough


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm edited a comment on issue #10369: Using `LIMIT 0` in SQL SELECT query causes `sqlOuterLimit` to be ignored

Posted by GitBox <gi...@apache.org>.
gianm edited a comment on issue #10369:
URL: https://github.com/apache/druid/issues/10369#issuecomment-689199020


   I think #10279 fixed this:
   
   - Changed line at https://github.com/apache/druid/pull/10279/files#diff-7188e8cc823080d9f21c10a2757f738dR977
   - Test at https://github.com/apache/druid/pull/10279/files#diff-190f8eaf9dd09e8d7ae0564804286afcR6536
   
   Can you check if the bug is still there in master?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm commented on issue #10369: Using `LIMIT 0` in SQL SELECT query causes `sqlOuterLimit` to be ignored

Posted by GitBox <gi...@apache.org>.
gianm commented on issue #10369:
URL: https://github.com/apache/druid/issues/10369#issuecomment-689199020


   I think #10279 fixed this: https://github.com/apache/druid/pull/10279/files#diff-190f8eaf9dd09e8d7ae0564804286afcR6536
   
   Can you check if the bug is still there in master?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] vogievetsky commented on issue #10369: Using `LIMIT 0` in SQL SELECT query causes `sqlOuterLimit` to be ignored

Posted by GitBox <gi...@apache.org>.
vogievetsky commented on issue #10369:
URL: https://github.com/apache/druid/issues/10369#issuecomment-881666012


   This has indeed been fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm edited a comment on issue #10369: Using `LIMIT 0` in SQL SELECT query causes `sqlOuterLimit` to be ignored

Posted by GitBox <gi...@apache.org>.
gianm edited a comment on issue #10369:
URL: https://github.com/apache/druid/issues/10369#issuecomment-689199020


   I think #10279 fixed this: https://github.com/apache/druid/pull/10279/files#diff-7188e8cc823080d9f21c10a2757f738dR977, test at https://github.com/apache/druid/pull/10279/files#diff-190f8eaf9dd09e8d7ae0564804286afcR6536
   
   Can you check if the bug is still there in master?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] vogievetsky closed issue #10369: Using `LIMIT 0` in SQL SELECT query causes `sqlOuterLimit` to be ignored

Posted by GitBox <gi...@apache.org>.
vogievetsky closed issue #10369:
URL: https://github.com/apache/druid/issues/10369


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org