[GitHub] [spark] zero323 commented on a change in pull request #33900: [SPARK-36654][PYTHON] Drop type ignores from numpy imports

[GitBox <gi...@apache.org>]

zero323 commented on a change in pull request #33900:
URL: https://github.com/apache/spark/pull/33900#discussion_r727412156



##########
File path: examples/src/main/python/sql/arrow.py
##########
@@ -32,7 +32,7 @@
 
 
 def dataframe_with_arrow_example(spark):
-    import numpy as np  # type: ignore[import]
+    import numpy as np

Review comment:
       Sorry for a delay @HyukjinKwon. It too longer longer than I expected, to test this properly (I had to isolate things, because mypy cache + some undefined quirks, caused unpredictable behavior locally, even if tested within conda / venv environments) .
   
   Long story short ‒ this shouldn't really impact end users.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org