You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/14 14:01:06 UTC
[GitHub] [incubator-doris] cambyzju opened a new pull request, #10140: [fix] croaringbitmap compile support USE_AVX2=0
cambyzju opened a new pull request, #10140:
URL: https://github.com/apache/incubator-doris/pull/10140
Now third party package `CRoaring` will turn AVX2 dynamically.
We need to FORCE disable AVX2 while release `no-avx` Doris package.
# Proposed changes
Issue Number: close #10100
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] compiletheworld commented on a diff in pull request #10140: [fix] croaringbitmap compile support USE_AVX2=0
Posted by GitBox <gi...@apache.org>.
compiletheworld commented on code in PR #10140:
URL: https://github.com/apache/incubator-doris/pull/10140#discussion_r898622856
##########
thirdparty/build-thirdparty.sh:
##########
@@ -787,7 +787,7 @@ build_bitshuffle() {
build_croaringbitmap() {
avx_flag=
if [ ! -z "$USE_AVX2" -a "$USE_AVX2" -eq 0 ];then
- echo "FORCE disable AVX for croaringbitmap"
+ echo "set USE_AVX2=$USE_AVX2 to FORCE disable AVX2 in croaringbitmap"
Review Comment:
This prompt seems confusing, is it `disable` or `enable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #10140: [fix] croaringbitmap compile support USE_AVX2=0
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10140:
URL: https://github.com/apache/incubator-doris/pull/10140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on pull request #10140: [fix] croaringbitmap compile support USE_AVX2=0
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on PR #10140:
URL: https://github.com/apache/incubator-doris/pull/10140#issuecomment-1155881596
P0 regression failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #10140: [fix] croaringbitmap compile support USE_AVX2=0
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #10140:
URL: https://github.com/apache/incubator-doris/pull/10140#discussion_r898634098
##########
thirdparty/build-thirdparty.sh:
##########
@@ -787,7 +787,7 @@ build_bitshuffle() {
build_croaringbitmap() {
avx_flag=
if [ ! -z "$USE_AVX2" -a "$USE_AVX2" -eq 0 ];then
- echo "FORCE disable AVX for croaringbitmap"
+ echo "set USE_AVX2=$USE_AVX2 to FORCE disable AVX2 in croaringbitmap"
Review Comment:
Only after set USE_AVX2=0, it will reach here. It means disable AVX2.
Otherwise we will open AVX2 and there is no message printed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] cambyzju commented on pull request #10140: [fix] croaringbitmap compile support USE_AVX2=0
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #10140:
URL: https://github.com/apache/incubator-doris/pull/10140#issuecomment-1155910334
> P0 regression failed
Every body's P0 regression failed. It looks like the BE for regression is crashed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10140: [fix] croaringbitmap compile support USE_AVX2=0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10140:
URL: https://github.com/apache/incubator-doris/pull/10140#issuecomment-1156067170
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10140: [fix] croaringbitmap compile support USE_AVX2=0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10140:
URL: https://github.com/apache/incubator-doris/pull/10140#issuecomment-1156067208
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org