You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2019/01/08 23:32:09 UTC
[kudu-CR] rpc: add TCP socket statistics to /rpcz
Hello Michael Ho, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12184
to review the following change.
Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................
rpc: add TCP socket statistics to /rpcz
This adds the ability to fetch various bits of socket-level information
for each RPC connection and publish the info into /rpcz. The information
itself is fetched using getsockopt(TCP_INFO) as well as ioctls to check
the current send and receive queue lengths.
This data can help resolve whether a use case is network bound or bound
by the application itself. For example, a high number of retransmitted
packets can indicate that the network path to the receiver is
overloaded.
Eventually we may want to expose some of this information on a per-call
basis. However, doing so is quite tricky, since 'send()' completes when
the data has been placed into the outbound packet queue and doesn't wait
until the data is ACKed. We'd need to defer checking for retransmissions
until all of the data has been ACKed, which is at some indeterminate
point in the future. The very newest kernels allow subscribing to such
notifications (along with lots of interesting stats) but, given none of
that is available in el7, it's probably not worth tackling at this
point.
Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/connection.h
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/outbound_call.h
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/reactor.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_introspection.proto
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/server/rpcz-path-handler.cc
14 files changed, 299 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/12184/1
--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[kudu-CR] rpc: add TCP socket statistics to /rpcz
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................
rpc: add TCP socket statistics to /rpcz
This adds the ability to fetch various bits of socket-level information
for each RPC connection and publish the info into /rpcz. The information
itself is fetched using getsockopt(TCP_INFO) as well as ioctls to check
the current send and receive queue lengths.
This data can help resolve whether a use case is network bound or bound
by the application itself. For example, a high number of retransmitted
packets can indicate that the network path to the receiver is
overloaded.
Eventually we may want to expose some of this information on a per-call
basis. However, doing so is quite tricky, since 'send()' completes when
the data has been placed into the outbound packet queue and doesn't wait
until the data is ACKed. We'd need to defer checking for retransmissions
until all of the data has been ACKed, which is at some indeterminate
point in the future. The very newest kernels allow subscribing to such
notifications (along with lots of interesting stats) but, given none of
that is available in el7, it's probably not worth tackling at this
point.
Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/connection.h
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/outbound_call.h
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/reactor.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_introspection.proto
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/server/rpcz-path-handler.cc
14 files changed, 308 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/12184/2
--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] rpc: add TCP socket statistics to /rpcz
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................
rpc: add TCP socket statistics to /rpcz
This adds the ability to fetch various bits of socket-level information
for each RPC connection and publish the info into /rpcz. The information
itself is fetched using getsockopt(TCP_INFO) as well as ioctls to check
the current send and receive queue lengths.
This data can help resolve whether a use case is network bound or bound
by the application itself. For example, a high number of retransmitted
packets can indicate that the network path to the receiver is
overloaded.
Eventually we may want to expose some of this information on a per-call
basis. However, doing so is quite tricky, since 'send()' completes when
the data has been placed into the outbound packet queue and doesn't wait
until the data is ACKed. We'd need to defer checking for retransmissions
until all of the data has been ACKed, which is at some indeterminate
point in the future. The very newest kernels allow subscribing to such
notifications (along with lots of interesting stats) but, given none of
that is available in el7, it's probably not worth tackling at this
point.
Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Reviewed-on: http://gerrit.cloudera.org:8080/12184
Reviewed-by: Will Berkeley <wd...@gmail.com>
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/connection.h
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/outbound_call.h
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/reactor.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_introspection.proto
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/server/rpcz-path-handler.cc
14 files changed, 313 insertions(+), 45 deletions(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] rpc: add TCP socket statistics to /rpcz
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................
Patch Set 2: Code-Review+2
LGTM but would appreciate addressing PhilZ's feedback as well.
--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 28 Jan 2019 22:43:57 +0000
Gerrit-HasComments: No
[kudu-CR] rpc: add TCP socket statistics to /rpcz
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12184/2/src/kudu/rpc/rpc_introspection.proto
File src/kudu/rpc/rpc_introspection.proto:
http://gerrit.cloudera.org:8080/#/c/12184/2/src/kudu/rpc/rpc_introspection.proto@53
PS2, Line 53: message SocketStatsPB {
> Do these need more documentation, or a pointer to the relevant header file?
Done
--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 28 Jan 2019 23:13:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] rpc: add TCP socket statistics to /rpcz
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................
rpc: add TCP socket statistics to /rpcz
This adds the ability to fetch various bits of socket-level information
for each RPC connection and publish the info into /rpcz. The information
itself is fetched using getsockopt(TCP_INFO) as well as ioctls to check
the current send and receive queue lengths.
This data can help resolve whether a use case is network bound or bound
by the application itself. For example, a high number of retransmitted
packets can indicate that the network path to the receiver is
overloaded.
Eventually we may want to expose some of this information on a per-call
basis. However, doing so is quite tricky, since 'send()' completes when
the data has been placed into the outbound packet queue and doesn't wait
until the data is ACKed. We'd need to defer checking for retransmissions
until all of the data has been ACKed, which is at some indeterminate
point in the future. The very newest kernels allow subscribing to such
notifications (along with lots of interesting stats) but, given none of
that is available in el7, it's probably not worth tackling at this
point.
Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
---
M src/kudu/rpc/connection.cc
M src/kudu/rpc/connection.h
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/outbound_call.h
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/reactor.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_introspection.proto
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/server/rpcz-path-handler.cc
14 files changed, 313 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/12184/3
--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] rpc: add TCP socket statistics to /rpcz
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc
File src/kudu/rpc/connection.cc:
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc@959
PS1, Line 959:
> nit: are these tabs? If yes, replace with spaces.
huh, perils of flipping between different editors on different machines I guess. I'm surprised lint didn't complain
--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 09 Jan 2019 20:52:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] rpc: add TCP socket statistics to /rpcz
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................
Patch Set 1:
(4 comments)
LGTM and it compiles and runs on macOS. Just some nits so far.
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc
File src/kudu/rpc/connection.cc:
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc@959
PS1, Line 959:
nit: are these tabs? If yes, replace with spaces.
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc@968
PS1, Line 968:
nit: ditto
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc@970
PS1, Line 970:
ditto
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/reactor.h
File src/kudu/rpc/reactor.h:
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/reactor.h@152
PS1, Line 152: DumpRunningRpcs
> should probably rename this and related calls
yep, that would be nice to match the name of those methods wrt new names for corresponding PB structures.
--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 09 Jan 2019 20:48:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] rpc: add TCP socket statistics to /rpcz
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 28 Jan 2019 23:14:39 +0000
Gerrit-HasComments: No
[kudu-CR] rpc: add TCP socket statistics to /rpcz
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................
Patch Set 2:
(1 comment)
Looks reasonable to me!
http://gerrit.cloudera.org:8080/#/c/12184/2/src/kudu/rpc/rpc_introspection.proto
File src/kudu/rpc/rpc_introspection.proto:
http://gerrit.cloudera.org:8080/#/c/12184/2/src/kudu/rpc/rpc_introspection.proto@53
PS2, Line 53: message SocketStatsPB {
Do these need more documentation, or a pointer to the relevant header file?
--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 28 Jan 2019 21:59:22 +0000
Gerrit-HasComments: Yes
[kudu-CR] rpc: add TCP socket statistics to /rpcz
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc
File src/kudu/rpc/connection.cc:
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc@968
PS1, Line 968:
> nit: ditto
Done
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc@970
PS1, Line 970:
> ditto
Done
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/reactor.h
File src/kudu/rpc/reactor.h:
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/reactor.h@152
PS1, Line 152: DumpRunningRpcs
> should probably rename this and related calls
Done
--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 28 Jan 2019 04:00:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] rpc: add TCP socket statistics to /rpcz
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/reactor.h
File src/kudu/rpc/reactor.h:
http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/reactor.h@152
PS1, Line 152: DumpRunningRpcs
should probably rename this and related calls
--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 09 Jan 2019 04:35:25 +0000
Gerrit-HasComments: Yes