Re: [PR] Change wildcard qualifier type from `String` to `TableReference` [datafusion]

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #11073:
URL: https://github.com/apache/datafusion/pull/11073#discussion_r1650041705


##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -369,7 +369,8 @@ message LogicalExprNode {
 }
 
 message Wildcard {
-  string qualifier = 1;
+  string qualifier = 1 [deprecated = true];
+  TableReference relation = 2;

Review Comment:
   > Also, I'm not sure if we are allowed to make breaking changes to protobuf here. If we do, I can simply change the type of qualifier to make the code simpler.
   
   At the moment, we don't try to maintain any backwards compatibility, thus I think we should opt for simpler code
   
   https://github.com/apache/datafusion/blob/8aad2082994bdea14eaf7d0e8c177aa3ce9af67b/datafusion/proto/src/lib.rs#L37-L42



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org