You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yf13 (via GitHub)" <gi...@apache.org> on 2024/01/15 23:42:30 UTC
[PR] tools/export: add hello_zig support in kernel mode for linux host [nuttx]
yf13 opened a new pull request, #11548:
URL: https://github.com/apache/nuttx/pull/11548
## Summary
Export Zig related macros to `nuttx-export-x.y.z.tar.gz` for apps side to build hello_zig app on Linux host.
## Impact
None
## Testing
checked with `rv-virt/knsh32`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tools/export: add hello_zig support in kernel mode for linux host [nuttx]
Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on code in PR #11548:
URL: https://github.com/apache/nuttx/pull/11548#discussion_r1452822372
##########
tools/Zig.defs:
##########
@@ -39,4 +39,6 @@ endif
# Convert cortex-xxx/sifive-exx to cortex_xxx/sifive_exx
+ifneq ($(LLVM_CPUTYPE),)
ZIGFLAGS += -mcpu $(subst -,_,$(LLVM_CPUTYPE))
+endif
Review Comment:
No idea, it was there before and I got empty string during local test, so I guarded it to move ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tools/export: add hello_zig support in kernel mode for linux host [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #11548:
URL: https://github.com/apache/nuttx/pull/11548#discussion_r1452820167
##########
tools/Zig.defs:
##########
@@ -39,4 +39,6 @@ endif
# Convert cortex-xxx/sifive-exx to cortex_xxx/sifive_exx
+ifneq ($(LLVM_CPUTYPE),)
ZIGFLAGS += -mcpu $(subst -,_,$(LLVM_CPUTYPE))
+endif
Review Comment:
Any idea why only Zig does this kind of substitution for LLVM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tools/export: add hello_zig support in kernel mode for linux host [nuttx]
Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on code in PR #11548:
URL: https://github.com/apache/nuttx/pull/11548#discussion_r1452979308
##########
tools/Zig.defs:
##########
@@ -39,4 +39,6 @@ endif
# Convert cortex-xxx/sifive-exx to cortex_xxx/sifive_exx
+ifneq ($(LLVM_CPUTYPE),)
ZIGFLAGS += -mcpu $(subst -,_,$(LLVM_CPUTYPE))
+endif
Review Comment:
@acassis it seems that "sim/wamr" is blocking the CI checks, will push again later until it is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tools/export: add hello_zig support in kernel mode for linux host [nuttx]
Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on code in PR #11548:
URL: https://github.com/apache/nuttx/pull/11548#discussion_r1452822372
##########
tools/Zig.defs:
##########
@@ -39,4 +39,6 @@ endif
# Convert cortex-xxx/sifive-exx to cortex_xxx/sifive_exx
+ifneq ($(LLVM_CPUTYPE),)
ZIGFLAGS += -mcpu $(subst -,_,$(LLVM_CPUTYPE))
+endif
Review Comment:
No idea, it was there before. I got empty string during local test, so guarded it to move ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tools/export: add hello_zig support in kernel mode for linux host [nuttx]
Posted by "yf13 (via GitHub)" <gi...@apache.org>.
yf13 commented on code in PR #11548:
URL: https://github.com/apache/nuttx/pull/11548#discussion_r1452979308
##########
tools/Zig.defs:
##########
@@ -39,4 +39,6 @@ endif
# Convert cortex-xxx/sifive-exx to cortex_xxx/sifive_exx
+ifneq ($(LLVM_CPUTYPE),)
ZIGFLAGS += -mcpu $(subst -,_,$(LLVM_CPUTYPE))
+endif
Review Comment:
@acassis it seems that `sim/wamr` is blocking the CI checks? will push again later until it is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tools/export: add hello_zig support in kernel mode for linux host [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #11548:
URL: https://github.com/apache/nuttx/pull/11548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] tools/export: add hello_zig support in kernel mode for linux host [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #11548:
URL: https://github.com/apache/nuttx/pull/11548#issuecomment-1893160016
please rebase to the last master, ci break is fixed.@yf13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org