Re: [PR] Core: Interface based DataFile reader and writer API [iceberg]

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r2255170953


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -136,6 +138,15 @@ private Parquet() {}
           "parquet.read.support.class",
           "parquet.crypto.factory.class");
 
+  private static final int MAX_RECORDS_PER_BATCH_DEFAULT = 10000;
+
+  public static final String WRITER_VERSION_KEY = "parquet.writer.version";
+
+  /**
+   * @deprecated Since 1.10.0, will be removed in 1.11.0. Use {@link
+   *     FormatModelRegistry#writeBuilder(FileFormat, String, EncryptedOutputFile)} instead.
+   */
+  @Deprecated

Review Comment:
   This should not be deprecated. I think that we want Parquet to continue to expose this without going through the registry. This is a valid thing for Parquet to expose.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org