You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/07 12:43:38 UTC

[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #1408: IGNITE-18233: Add a green color to the sql repl prompt

PakhomovAlexander commented on code in PR #1408:
URL: https://github.com/apache/ignite-3/pull/1408#discussion_r1042158417


##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/commands/sql/SqlReplCommand.java:
##########
@@ -96,7 +99,7 @@ public void run() {
             // When passing white space to this command, picocli will treat it as a positional argument
             if (execOptions == null || (execOptions.command != null && execOptions.command.isBlank())) {
                 replExecutorProvider.get().execute(Repl.builder()
-                        .withPromptProvider(() -> "sql-cli> ")
+                        .withPromptProvider(() -> ansi(fg(Color.GREEN).mark("sql-cli > ")))

Review Comment:
   our default prompt looks like `[disconnected]>` so there is no space before `>`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org