[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #328: [YUNIKORN-870] Enhance application-related REST APIs

[GitBox <gi...@apache.org>]

wilfred-s commented on a change in pull request #328:
URL: https://github.com/apache/incubator-yunikorn-core/pull/328#discussion_r817942760



##########
File path: pkg/scheduler/objects/application.go
##########
@@ -77,6 +78,7 @@ type Application struct {
 	execTimeout          time.Duration          // execTimeout for the application run
 	placeholderTimer     *time.Timer            // placeholder replace timer
 	gangSchedulingStyle  string                 // gang scheduling style can be hard (after timeout we fail the application), or soft (after timeeout we schedule it as a normal application)
+	finishedTime         *time.Time             // the time of finishing this application. the default value is nil

Review comment:
       see comment below




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org