[GitHub] csquire commented on issue #2877: RootCAProvider certificate validation fails if default interface has multiple IP addresses

[GitBox <gi...@apache.org>]

csquire commented on issue #2877: RootCAProvider certificate validation fails if default interface has multiple IP addresses
URL: https://github.com/apache/cloudstack/issues/2877#issuecomment-427222978
 
 
   @rhtyd thanks, that was quick! I had actually patched our test system by adding a custom CA provider as a plugin with the same approach and it worked well. I was going to submit a PR, but you beat me to it.  Anyways, I copied your new NetUtils.getAllDefaultNicIps() method to my plugin and quickly deployed it and it works well. The only difference I noticed is that yours places the IPV6 address in the certificate (in addition to both IPV4 addresses) where my implementation did not. So, LGTM. :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services