You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Adrian Crum (JIRA)" <ji...@apache.org> on 2007/06/13 02:21:26 UTC
[jira] Created: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Add OFBiz User Time Zone Selection Capability
---------------------------------------------
Key: OFBIZ-1079
URL: https://issues.apache.org/jira/browse/OFBIZ-1079
Project: OFBiz
Issue Type: Improvement
Components: framework
Reporter: Adrian Crum
Priority: Minor
Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Use's can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1079:
-------------------------------
Attachment: tz_select.patch
Updated patch. Added setSessionTimeZone event, changed drop-down lists to follow pattern recommended by David Jones.
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1079:
-------------------------------
Attachment: tz_select.patch
Attached patch adds the feature.
Notes:
I piggybacked the time zone setting onto the SetSessionLocale service so that we wouldn't have to modify all of the controller.xml files.
The list contents can be controlled with the general.properties file - just like the locales.
The list contents may seem redundant. For some reason TimeZone.getDescription outputs the exact same text for different time zone IDs. I tried populating the list with the IDs - which is more informative, but then the list doesn't get translated when the locale is changed. I'm open to any ideas on how to improve the list.
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Use's can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1079:
-------------------------------
Attachment: tz_select.patch
Oops, last patch had an error. Improved patch.
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Oleg Andreyev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Andreyev updated OFBIZ-1079:
---------------------------------
Attachment: timezones.xml
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Oleg Andreyev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504541 ]
Oleg Andreyev commented on OFBIZ-1079:
--------------------------------------
Adrian, why not place timezone descriptions in Enumeration entity?
I attached the file that isn't complete solution, just part of my another incompleted work. May be it can be helpful.
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1079.
----------------------------------
Resolution: Fixed
Well done Adrian,
1069, 1079, 1089 : easy to follow ;o)
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Oleg Andreyev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504929 ]
Oleg Andreyev commented on OFBIZ-1079:
--------------------------------------
Adrian,
It's possible to translate enumeration description fields to any language with help of *EntityLabels.properties and GenericEntity.get(String name, Locale locale) method. If it's really interesting, I can done this work in a week.
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504946 ]
Adrian Crum commented on OFBIZ-1079:
------------------------------------
Oleg,
Wait a little while until we get more comments from other developers. Also, I would like to research this further. I would rather use something built into Java than have to duplicate all of those display names.
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504564 ]
Adrian Crum commented on OFBIZ-1079:
------------------------------------
Btw, anyone wanting to read about some of the considerations/issues in calendars, timezones, etc, should check out these links:
http://www.onjava.com/pub/a/onjava/2003/06/05/java_calendar.html
http://www.icu-project.org/docs/papers/international_calendars_in_java.html
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Crum updated OFBIZ-1079:
-------------------------------
Description:
Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
was:
Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Use's can select a time zone and then their selection will be persisted.
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504547 ]
Adrian Crum commented on OFBIZ-1079:
------------------------------------
Oleg,
Thank you for the xml file! That is an interesting idea, but the enumeration description field would be in one language only. What happens if the user switches to another locale?
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504574 ]
Jacopo Cappellato commented on OFBIZ-1079:
------------------------------------------
Adrian,
thanks for the link, I will read these documents as soon as I have some free time.
As a side note: are you aware that we are already using the icu jar? It is in the base component and we are using it at least to render a numeric value into a text format (for checks) and probably also to format numbers.
You could probably use it also for the calendar stuff.
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504625 ]
Jacopo Cappellato commented on OFBIZ-1079:
------------------------------------------
I have quickly reviewed and applied to my local copy the patch.
I will let it run for a while and then I'll commit (if Jacques, or others, will comment on it, or beat me it that would be great).
One small thing I don't like much is the setTimeZone code 'hidden' in the setSessionLocale method: I understand your motivations (i.e. not changing all the controllers) and they make sense, but maybe having it in a new method (temporarily called from the setSessionLocale) would be better.... but maybe it is a minor issue: what do others think about this?
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato reassigned OFBIZ-1079:
----------------------------------------
Assignee: Jacopo Cappellato
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504597 ]
Adrian Crum commented on OFBIZ-1079:
------------------------------------
Jacopo,
Yes, I just realized we have that library in the project. I am working on including the com.ibm.icu.util.Holiday class in my calendar project here at work.
As far as the OFBiz project is concerned, I don't see any additional functionality that the icu jar provides. Unless there are members of the community who are interested in a personal calendar...
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504616 ]
Jacques Le Roux commented on OFBIZ-1079:
----------------------------------------
Adrian,
If nobody beats me I will have a look tomorrow or at least this week-end
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506093 ]
Jacopo Cappellato commented on OFBIZ-1079:
------------------------------------------
Adrian,
your last patch is in rev. 548646, thanks.
Adrian, Oleg, all,
can we close this issue now?
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506186 ]
Adrian Crum commented on OFBIZ-1079:
------------------------------------
Jacopo,
Thank you for committing this! We can close this issue and fine-tune the drop-down in another issue.
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1079) Add OFBiz User Time Zone Selection
Capability
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504601 ]
Adrian Crum commented on OFBIZ-1079:
------------------------------------
One more thing about this Jira issue - I need this committed so I can fix the problems in the Workeffort calendar feature. If the display of the time zones isn't perfect, then that's okay - I need the infrastructure this patch provides so I can continue my work. If someone wants to come along and change the UI stuff and make it more elegant - that's cool. For now I just need a way for a user to select a time zone.
I'm not trying to pressure anyone, I'm just trying to make a point that some of this is needed to fix other things in the Workeffort component's calendar feature.
> Add OFBiz User Time Zone Selection Capability
> ---------------------------------------------
>
> Key: OFBIZ-1079
> URL: https://issues.apache.org/jira/browse/OFBIZ-1079
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: timezones.xml, tz_select.patch, tz_select.patch
>
>
> Add a lastTimeZone field to the UserLogin entity and a time zone drop-down list to the masthead. Users can select a time zone and then their selection will be persisted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.