You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Weijie Guo (Jira)" <ji...@apache.org> on 2023/03/02 10:39:00 UTC
[jira] [Comment Edited] (FLINK-31297) FineGrainedSlotManagerTest.testTaskManagerRegistrationDeductPendingTaskManager unstable when running it a single time
[ https://issues.apache.org/jira/browse/FLINK-31297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695649#comment-17695649 ]
Weijie Guo edited comment on FLINK-31297 at 3/2/23 10:38 AM:
-------------------------------------------------------------
[~xzw0223] Thanks for looking into this, but I do not think directly change the expected value is the right approach. As the comments before the assertion, we can see that `task manager with allocated slot cannot deduct pending task manager`, the expected behavior is the pending taskmanager will not be reduced to 0, right?
was (Author: weijie guo):
[~xzw0223] Thanks for looking into this, but I do not think directly change the expected value is the right approach. As the comments before the assertion, we can see that `task manager with allocated slot cannot deduct pending task manager`, the expected behavior is the pending taskmanager will not deduct to zero, right?
> FineGrainedSlotManagerTest.testTaskManagerRegistrationDeductPendingTaskManager unstable when running it a single time
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-31297
> URL: https://issues.apache.org/jira/browse/FLINK-31297
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
> Affects Versions: 1.17.0
> Reporter: Matthias Pohl
> Assignee: Weihua Hu
> Priority: Blocker
> Labels: test-stability
>
> We noticed a weird test-instability in {{FineGrainedSlotManagerTest.testTaskManagerRegistrationDeductPendingTaskManager}} when switching to sequential test execution (see FLINK-31278). I couldn't reproduce it in 1.16, therefore, marking it as a blocker for now. But it feels to be more of a test code issue.
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=46671&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=9695
> {code}
> Mar 01 15:20:17 [ERROR] org.apache.flink.runtime.resourcemanager.slotmanager.FineGrainedSlotManagerTest.testTaskManagerRegistrationDeductPendingTaskManager Time elapsed: 0.746 s <<< FAILURE!
> Mar 01 15:20:17 java.lang.AssertionError:
> Mar 01 15:20:17
> Mar 01 15:20:17 Expected size: 1 but was: 0 in:
> Mar 01 15:20:17 []
> Mar 01 15:20:17 at org.apache.flink.runtime.resourcemanager.slotmanager.FineGrainedSlotManagerTest.testTaskManagerRegistrationDeductPendingTaskManager(FineGrainedSlotManagerTest.java:209)
> Mar 01 15:20:17
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)