[GitHub] [geode-native] albertogpz commented on a change in pull request #621: GEODE-8213: Switch SerializationRegistry spinlock to mutex

[GitBox <gi...@apache.org>]

albertogpz commented on a change in pull request #621:
URL: https://github.com/apache/geode-native/pull/621#discussion_r444704517



##########
File path: cppcache/src/SerializationRegistry.hpp
##########
@@ -79,10 +80,10 @@ class TheTypeMap {
   std::unordered_map<internal::DSFid, TypeFactoryMethod>
       m_dataSerializableFixedIdMap;
   std::unordered_map<std::string, TypeFactoryMethodPdx> m_pdxSerializableMap;
-  mutable util::concurrent::spinlock_mutex m_dataSerializablePrimitiveMapLock;
-  mutable util::concurrent::spinlock_mutex m_dataSerializableMapLock;
-  mutable util::concurrent::spinlock_mutex m_dataSerializableFixedIdMapLock;
-  mutable util::concurrent::spinlock_mutex m_pdxSerializableMapLock;
+  mutable std::mutex m_dataSerializablePrimitiveMapLock;

Review comment:
       I made the changes according to your proposal.
   Nevertheles according to the CONTRIBUTING.md file we should be following Google's C++ style guide. According to it, the member variables should be named like ```data_serializable_map_mutex_```.
   Is there any other style guide I am not aware of?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org