You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/04/16 03:58:37 UTC

[GitHub] [incubator-echarts] Ovilia opened a new pull request #12444: WIP(legend): more intuitive legend design

Ovilia opened a new pull request #12444: WIP(legend): more intuitive legend design
URL: https://github.com/apache/incubator-echarts/pull/12444
 
 
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [x] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   Update default legend style so that the icons looks more intuitively like that of the series.
   
   ### Fixed issues
   
   <!--
   - #xxxx: ...
   -->
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   
   Legend for line series only have the color of the series, lacking `itemStyle.borderWidth`, `itemStyle.borderColor`, `lineStyle.color`, `lineStyle.borderColor` and etc.
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   ### After: How is it fixed in this PR?
   
   Legend for line series looks more like that of the series.
   `emptyCircle` has been changed to `circle`.
   
   <img width="1349" alt="屏幕快照 2020-04-16 11 54 58" src="https://user-images.githubusercontent.com/779050/79412906-25618400-7fd9-11ea-899b-b2febcdad606.png">
   
   See `test/legend-style.html` for more info.
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [x] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   `symbol` of `emptyCircle` has been deprecated.
   
   ### Related test cases or examples to use the new APIs
   
   `test/legend-style.html`
   
   
   ## TODO
   
   - [ ] Compat `emptyCircle` in other cases
   - [ ] Support other series (scatter series and etc.)
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Ovilia closed pull request #12444: WIP(legend): more intuitive legend design

Posted by GitBox <gi...@apache.org>.
Ovilia closed pull request #12444:
URL: https://github.com/apache/echarts/pull/12444


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12444: WIP(legend): more intuitive legend design

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12444: WIP(legend): more intuitive legend design
URL: https://github.com/apache/incubator-echarts/pull/12444#issuecomment-614402126
 
 
   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] Ovilia commented on pull request #12444: WIP(legend): more intuitive legend design

Posted by GitBox <gi...@apache.org>.
Ovilia commented on pull request #12444:
URL: https://github.com/apache/echarts/pull/12444#issuecomment-787782932


   Too many conflicts. Close this PR and open a new open later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org