[GitHub] [ozone] neils-dev commented on a diff in pull request #4027: HDDS-7570. Provide a shareable ofs://temp directory

[GitBox <gi...@apache.org>]

neils-dev commented on code in PR #4027:
URL: https://github.com/apache/ozone/pull/4027#discussion_r1063947406


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java:
##########
@@ -133,6 +133,7 @@ private void addPropertiesNotInXml() {
         OMConfigKeys.OZONE_RANGER_HTTPS_ADDRESS_KEY,
         OMConfigKeys.OZONE_OM_RANGER_HTTPS_ADMIN_API_USER,
         OMConfigKeys.OZONE_OM_RANGER_HTTPS_ADMIN_API_PASSWD,
+        OMConfigKeys.OZONE_OM_ENABLE_OFS_SHARED_TMP_DIR,

Review Comment:
   Adding `ozone.om.enable.ofs.shared.tmp.dir` to `ozone-default.xml`.  Currently default value set to false.  Should it remain, or enable it by default?



##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java:
##########
@@ -191,7 +198,7 @@ public static Path getBucketPath() {
   }
 
   @Rule
-  public Timeout globalTimeout = Timeout.seconds(300);
+  public Timeout globalTimeout = Timeout.seconds(3000);

Review Comment:
   Left over from testing.  Corrected.  Thanks!



##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OFSPath.java:
##########
@@ -102,7 +108,12 @@ private void initOFSPath(URI uri, boolean endsWithSlash) {
         // TODO: Make this configurable in the future.
         volumeName = OFS_MOUNT_TMP_VOLUMENAME;
         try {
-          bucketName = getTempMountBucketNameOfCurrentUser();
+          if (conf.getBoolean(OZONE_OM_ENABLE_OFS_SHARED_TMP_DIR,
+              OZONE_OM_ENABLE_OFS_SHARED_TMP_DIR_DEFAULT)) {
+            bucketName = OFS_MOUNT_NAME_TMP;

Review Comment:
   > Do we want to make the shared temp bucket name configurable?
   
   Filing a jira, HDDS-7746 -
   https://issues.apache.org/jira/browse/HDDS-7746
   
   > Right now the value of OFS_MOUNT_NAME_TMP happens to be tmp, but the meaning of this constant is different. Perhaps define a new constant?
   
   Thanks.  Defined `OFS_SHARED_TMP_BUCKETNAME` as constant used for setting tmp dir bucketname to "tmp".



##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/TrashOzoneFileSystem.java:
##########
@@ -283,7 +285,9 @@ public FileStatus getFileStatus(Path path) throws IOException {
   }
 
   private OmKeyArgs constructOmKeyArgs(Path path) {
-    OFSPath ofsPath = new OFSPath(path);
+    /*OzoneConfiguration conf = getConf() == null ? new OzoneConfiguration() :
+        OzoneConfiguration.of(getConf());*/

Review Comment:
   Unneeded.  Thanks.  Removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org