You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/02 15:51:44 UTC
[GitHub] [spark] ArjunSharda opened a new pull request, #37056: (GitHub CI) Bump workflow versions
ArjunSharda opened a new pull request, #37056:
URL: https://github.com/apache/spark/pull/37056
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
This pull requests bumps some of the workflow versions as some are outdated. *Note, this has not been tested with an IDE, I just did some basic changes I spotted.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37056: (GitHub CI) Bump workflow versions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37056:
URL: https://github.com/apache/spark/pull/37056#issuecomment-1173267909
Let's file a JIRA. I think we should track it with a JIRA since technically we're upgrading the major versions of the plugins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37056: (GitHub CI) Bump workflow versions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37056:
URL: https://github.com/apache/spark/pull/37056#issuecomment-1173011011
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37056: [SPARK-39665][INFRA] Bump workflow versions in GitHub Actions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37056:
URL: https://github.com/apache/spark/pull/37056#issuecomment-1181953060
Do you think the other GitHub Actions are stabler? IMO, the situation is not different. There is no point to track one by one in case of all GitHub Action. I'd recommend to close this PR.
> > If there is no known issues affecting Apache Spark repository, let's avoid any risk by holding on this PR until `v3` become stable. As we see in the release history, it seems to be still changing in a fast pace unlike `v2`.
> >
> > * https://github.com/actions/cache/tags
>
> I can revert the cache versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #37056: [SPARK-39665][INFRA] Bump workflow versions in GitHub Actions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #37056:
URL: https://github.com/apache/spark/pull/37056#issuecomment-1181988831
Yes, setup-java is especially aggressive. So, @ArjunSharda , your approach initially didn't consider much about the GitHub Action's upgrade cadence and the risk on Apache Spark community side. To prevent accidental merging, let me close this PR. We can still continue our discussion about the necessity of this PR content.
> I think as per what I saw except setup-java it should be okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ArjunSharda closed pull request #37056: (GitHub CI) Bump workflow versions
Posted by GitBox <gi...@apache.org>.
ArjunSharda closed pull request #37056: (GitHub CI) Bump workflow versions
URL: https://github.com/apache/spark/pull/37056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ArjunSharda commented on pull request #37056: [SPARK-39665][INFRA] Bump workflow versions in GitHub Actions
Posted by GitBox <gi...@apache.org>.
ArjunSharda commented on PR #37056:
URL: https://github.com/apache/spark/pull/37056#issuecomment-1179857428
> If there is no known issues affecting Apache Spark repository, let's avoid any risk by holding on this PR until `v3` become stable. As we see in the release history, it seems to be still changing in a fast pace unlike `v2`.
>
> * https://github.com/actions/cache/tags
I can revert the cache versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ArjunSharda commented on pull request #37056: (GitHub CI) Bump workflow versions
Posted by GitBox <gi...@apache.org>.
ArjunSharda commented on PR #37056:
URL: https://github.com/apache/spark/pull/37056#issuecomment-1173272564
> Let's file a JIRA. I think we should track it with a JIRA since technically we're upgrading the major versions of the plugins.
Alright, made. https://issues.apache.org/jira/browse/SPARK-39665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #37056: [SPARK-39665][INFRA] Bump workflow versions in GitHub Actions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #37056: [SPARK-39665][INFRA] Bump workflow versions in GitHub Actions
URL: https://github.com/apache/spark/pull/37056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ArjunSharda commented on pull request #37056: [SPARK-39665][INFRA] Bump workflow versions in GitHub Actions
Posted by GitBox <gi...@apache.org>.
ArjunSharda commented on PR #37056:
URL: https://github.com/apache/spark/pull/37056#issuecomment-1181962737
> Do you think the other GitHub Actions are stabler? IMO, the situation is not different. There is no point to track one by one in case of all GitHub Action. I'd recommend to close this PR.
>
> > > If there is no known issues affecting Apache Spark repository, let's avoid any risk by holding on this PR until `v3` become stable. As we see in the release history, it seems to be still changing in a fast pace unlike `v2`.
> > >
> > > * https://github.com/actions/cache/tags
> >
> >
> > I can revert the cache versions
I think as per what I saw except setup-java it should be okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ArjunSharda commented on pull request #37056: (GitHub CI) Bump workflow versions
Posted by GitBox <gi...@apache.org>.
ArjunSharda commented on PR #37056:
URL: https://github.com/apache/spark/pull/37056#issuecomment-1173251977
> @ArjunSharda mind taking a look at https://spark.apache.org/contributing.html? We should file a JIRA, fix the title format, feel the PR description format, etc.
Hey, I thought a JIRA would not be needed as it's a minor change with versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ArjunSharda commented on pull request #37056: [SPARK-39665][INFRA] Bump workflow versions in GitHub Actions
Posted by GitBox <gi...@apache.org>.
ArjunSharda commented on PR #37056:
URL: https://github.com/apache/spark/pull/37056#issuecomment-1176075656
> May I ask the reason why we need this, @ArjunSharda ?
Not needed, but the current versions used are outdated and could be bumped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org