You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/01 17:31:11 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #10219: fix: better backward compatibility for table viz
ktmud opened a new pull request #10219:
URL: https://github.com/apache/incubator-superset/pull/10219
### SUMMARY
Bump table viz to v0.14.5 (not released yet) to change default query mode from `aggregate` to `null` so it can have better backward compatibility. Currently existing tables in the old `NOT GROUP BY` mode will not open the `Query Mode: Raw` tab by default.
Accompanying superset-ui PR: https://github.com/apache-superset/superset-ui/pull/659
This bug was actually captured by #10206, but I was lazy and went with an easier fix.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Open an existing table chart querying raw columns:
Currently received:
<img src="https://user-images.githubusercontent.com/335541/86273903-c4802b80-bb85-11ea-9037-3163817ab073.png" width="300">
Expected:
<img src="https://user-images.githubusercontent.com/335541/86273789-9dc1f500-bb85-11ea-94cb-efb8dd8b7d0d.png" width="300">
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: apache-superset/superset-ui#659 #10113
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10219: fix: better backward compatibility for table viz
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10219:
URL: https://github.com/apache/incubator-superset/pull/10219#discussion_r448539627
##########
File path: superset-frontend/cypress-base/cypress/integration/explore/visualizations/table.test.js
##########
@@ -103,7 +103,8 @@ describe('Visualization > Table', () => {
it('Test table with columns and row limit', () => {
const formData = {
...VIZ_DEFAULTS,
- query_mode: 'raw',
+ // should still work when query_mode is not-set/invalid
+ query_mode: undefined,
Review comment:
There is another test below that sets `query_mode` with a value. Can make it more explicit though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10219: fix: better backward compatibility for table viz
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10219:
URL: https://github.com/apache/incubator-superset/pull/10219#discussion_r448535026
##########
File path: superset-frontend/cypress-base/cypress/integration/explore/visualizations/table.test.js
##########
@@ -103,7 +103,8 @@ describe('Visualization > Table', () => {
it('Test table with columns and row limit', () => {
const formData = {
...VIZ_DEFAULTS,
- query_mode: 'raw',
+ // should still work when query_mode is not-set/invalid
+ query_mode: undefined,
Review comment:
should we keep the old test case _and_ add the new one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10219: fix: better backward compatibility for table viz
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10219:
URL: https://github.com/apache/incubator-superset/pull/10219#issuecomment-652555290
> also fixes #10215 ?
Yep
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud merged pull request #10219: fix: better backward compatibility for table viz
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #10219:
URL: https://github.com/apache/incubator-superset/pull/10219
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on pull request #10219: fix: better backward compatibility for table viz
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #10219:
URL: https://github.com/apache/incubator-superset/pull/10219#issuecomment-652554123
also fixes https://github.com/apache/incubator-superset/issues/10215 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai removed a comment on pull request #10219: fix: better backward compatibility for table viz
Posted by GitBox <gi...@apache.org>.
nytai removed a comment on pull request #10219:
URL: https://github.com/apache/incubator-superset/pull/10219#issuecomment-652554123
also fixes https://github.com/apache/incubator-superset/issues/10215 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org