You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/06/29 19:24:50 UTC

[GitHub] [arrow-adbc] lidavidm opened a new pull request, #866: feat(c/driver_manager,go/adbc,python): trim down error messages

lidavidm opened a new pull request, #866:
URL: https://github.com/apache/arrow-adbc/pull/866

   - Avoid useless prefixes and redundant information (like ADBC_ prefixes everywhere)
   - Trim out some internal bits (like exceptions technically being in _lib)
   
   Fixes #865.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-adbc] lidavidm merged pull request #866: feat(c/driver_manager,go/adbc,python): trim down error messages

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #866:
URL: https://github.com/apache/arrow-adbc/pull/866


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-adbc] lidavidm commented on pull request #866: feat(c/driver_manager,go/adbc,python): trim down error messages

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #866:
URL: https://github.com/apache/arrow-adbc/pull/866#issuecomment-1614788191

   I figured it out! (I finally got devtools installed; I always forget to deactivate Conda before using R...)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-adbc] paleolimbot commented on pull request #866: feat(c/driver_manager,go/adbc,python): trim down error messages

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #866:
URL: https://github.com/apache/arrow-adbc/pull/866#issuecomment-1614783061

   I'm not sure I can explain just by looking at the diff why `LogDriverRelease` stopped getting printed (I'm happy to take a look in a follow-up, just let me know).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-adbc] lidavidm commented on pull request #866: feat(c/driver_manager,go/adbc,python): trim down error messages

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #866:
URL: https://github.com/apache/arrow-adbc/pull/866#issuecomment-1614035587

   I need to fix the R tests here before merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-adbc] lidavidm commented on pull request #866: feat(c/driver_manager,go/adbc,python): trim down error messages

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #866:
URL: https://github.com/apache/arrow-adbc/pull/866#issuecomment-1613681774

   Before:
   
   ```
   E   adbc_driver_manager._lib.ProgrammingError: ADBC_STATUS_INVALID_ARGUMENT (5): [FlightSQL] Failure parsing the query.
   E   SQL Query SELECT
   E   startLine 1
   E   startColumn 6
   E   endLine 1
   E   endColumn 6
   ```
   
   After:
   
   ```
   E   adbc_driver_manager.ProgrammingError: INVALID_ARGUMENT: [FlightSQL] Failure parsing the query.
   E   SQL Query SELECT
   E   startLine 1
   E   startColumn 6
   E   endLine 1
   E   endColumn 6
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-adbc] lidavidm commented on pull request #866: feat(c/driver_manager,go/adbc,python): trim down error messages

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #866:
URL: https://github.com/apache/arrow-adbc/pull/866#issuecomment-1614717166

   Weird, unless I'm missing something, the R tests pass locally for me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org