You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/31 16:19:28 UTC
[GitHub] [superset] codecov[bot] edited a comment on pull request #13828: feat(alert/report): chart as csv format attachment for email and slack
codecov[bot] edited a comment on pull request #13828:
URL: https://github.com/apache/superset/pull/13828#issuecomment-811191608
# [Codecov](https://codecov.io/gh/apache/superset/pull/13828?src=pr&el=h1) Report
> Merging [#13828](https://codecov.io/gh/apache/superset/pull/13828?src=pr&el=desc) (3ca27aa) into [master](https://codecov.io/gh/apache/superset/commit/9d6832dc271fcea76302feb4273bd72a8b9d05ba?el=desc) (9d6832d) will **decrease** coverage by `0.20%`.
> The diff coverage is `88.65%`.
[](https://codecov.io/gh/apache/superset/pull/13828?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13828 +/- ##
==========================================
- Coverage 77.55% 77.34% -0.21%
==========================================
Files 935 935
Lines 47301 47363 +62
Branches 5907 5907
==========================================
- Hits 36685 36634 -51
- Misses 10472 10585 +113
Partials 144 144
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.62% <91.02%> (+0.01%)` | :arrow_up: |
| postgres | `80.65% <91.13%> (+0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.74% <91.13%> (-0.41%)` | :arrow_down: |
| sqlite | `80.21% <91.02%> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13828?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/13828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/13828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `62.52% <77.77%> (ø)` | |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `91.86% <80.00%> (-1.72%)` | :arrow_down: |
| [superset/utils/csv.py](https://codecov.io/gh/apache/superset/pull/13828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY3N2LnB5) | `93.75% <87.50%> (-6.25%)` | :arrow_down: |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/13828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.70% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `96.42% <100.00%> (+0.77%)` | :arrow_up: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `98.14% <100.00%> (+0.27%)` | :arrow_up: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `87.50% <100.00%> (+2.71%)` | :arrow_up: |
| [superset/reports/schemas.py](https://codecov.io/gh/apache/superset/pull/13828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.63% <100.00%> (+0.01%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/13828/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13828?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13828?src=pr&el=footer). Last update [9d6832d...3ca27aa](https://codecov.io/gh/apache/superset/pull/13828?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org