You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/23 20:00:25 UTC
[GitHub] [superset] yardz opened a new pull request #13304: test: change "data-test-id" to "data-test"
yardz opened a new pull request #13304:
URL: https://github.com/apache/superset/pull/13304
### SUMMARY
With the changes made in this PR #13292 the tests started to break.
This adapts the tests to the new configuration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13304: test: change data-test-id to data-test in FlashProvider
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13304:
URL: https://github.com/apache/superset/pull/13304#issuecomment-784514153
# [Codecov](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=h1) Report
> Merging [#13304](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=desc) (0b2df82) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **decrease** coverage by `19.01%`.
> The diff coverage is `35.55%`.
[](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13304 +/- ##
===========================================
- Coverage 77.15% 58.13% -19.02%
===========================================
Files 866 480 -386
Lines 45005 16003 -29002
Branches 5357 4130 -1227
===========================================
- Hits 34723 9304 -25419
+ Misses 10159 6699 -3460
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.13% <35.55%> (-0.38%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `5.88% <0.00%> (-80.64%)` | :arrow_down: |
| [...-frontend/src/common/components/Collapse/index.tsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL2luZGV4LnRzeA==) | `94.73% <ø> (ø)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `84.34% <ø> (-1.61%)` | :arrow_down: |
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `95.65% <ø> (-4.35%)` | :arrow_down: |
| [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `54.05% <ø> (-7.31%)` | :arrow_down: |
| [.../src/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLmpzeA==) | `86.73% <ø> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `56.52% <ø> (-5.51%)` | :arrow_down: |
| ... and [746 more](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=footer). Last update [9a05d6a...0b2df82](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #13304: test: change data-test-id to data-test in FlashProvider
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #13304:
URL: https://github.com/apache/superset/pull/13304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #13304: test: change data-test-id to data-test in FlashProvider
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #13304:
URL: https://github.com/apache/superset/pull/13304#issuecomment-784514153
# [Codecov](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=h1) Report
> Merging [#13304](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=desc) (0b2df82) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **decrease** coverage by `24.83%`.
> The diff coverage is `35.55%`.
[](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13304 +/- ##
===========================================
- Coverage 77.15% 52.31% -24.84%
===========================================
Files 866 478 -388
Lines 45005 15953 -29052
Branches 5357 4106 -1251
===========================================
- Hits 34723 8346 -26377
+ Misses 10159 7607 -2552
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.31% <35.55%> (-6.20%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `5.88% <0.00%> (-80.64%)` | :arrow_down: |
| [...-frontend/src/common/components/Collapse/index.tsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL2luZGV4LnRzeA==) | `94.73% <ø> (ø)` | |
| [...t-frontend/src/common/components/Tooltip/index.tsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1Rvb2x0aXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `81.81% <ø> (-18.19%)` | :arrow_down: |
| [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `94.80% <ø> (-5.20%)` | :arrow_down: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `83.47% <ø> (-2.48%)` | :arrow_down: |
| [...set-frontend/src/components/ModalTrigger/index.jsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWxUcmlnZ2VyL2luZGV4LmpzeA==) | `78.26% <ø> (-21.74%)` | :arrow_down: |
| [...dashboard/components/FiltersBadge/DetailsPanel.tsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9EZXRhaWxzUGFuZWwudHN4) | `51.35% <ø> (-10.02%)` | :arrow_down: |
| [.../src/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLmpzeA==) | `86.73% <ø> (ø)` | |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `56.52% <ø> (-5.51%)` | :arrow_down: |
| ... and [761 more](https://codecov.io/gh/apache/superset/pull/13304/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=footer). Last update [9a05d6a...0b2df82](https://codecov.io/gh/apache/superset/pull/13304?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz commented on pull request #13304: test: change "data-test-id" to "data-test"
Posted by GitBox <gi...@apache.org>.
yardz commented on pull request #13304:
URL: https://github.com/apache/superset/pull/13304#issuecomment-784473607
@ktmud I believe this has priority as it may be holding other PRs
Like this: https://github.com/apache/superset/pull/13302
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org