You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2021/06/24 21:33:38 UTC
[superset] branch hugh/cypress-db-conn-ui updated (5d784ec ->
2a31285)
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a change to branch hugh/cypress-db-conn-ui
in repository https://gitbox.apache.org/repos/asf/superset.git.
from 5d784ec add more test cases
new 4c467f5 saving this for development
new 2a31285 lit
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../cypress-base/cypress/integration/database/modal.test.ts | 7 +++++++
superset-frontend/cypress-base/cypress/support/index.ts | 2 +-
.../CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx | 1 +
.../src/views/CRUD/data/database/DatabaseModal/index.tsx | 2 ++
4 files changed, 11 insertions(+), 1 deletion(-)
[superset] 02/02: lit
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/cypress-db-conn-ui
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 2a31285f3cf818d499374da883286a1131d97dcb
Author: hughhhh <hu...@gmail.com>
AuthorDate: Thu Jun 24 14:32:20 2021 -0700
lit
---
.../cypress-base/cypress/integration/database/modal.test.ts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/superset-frontend/cypress-base/cypress/integration/database/modal.test.ts b/superset-frontend/cypress-base/cypress/integration/database/modal.test.ts
index d908d7f..f449846 100644
--- a/superset-frontend/cypress-base/cypress/integration/database/modal.test.ts
+++ b/superset-frontend/cypress-base/cypress/integration/database/modal.test.ts
@@ -71,6 +71,13 @@ describe('Add database', () => {
xit('show error alerts on sqlalchemy form', () => {});
xit('should succesfully connect to db w/ dynamic form', () => {});
xit('should succesfully connect to db w/ sqlalchemy form', () => {});
+ xit('should show preferred dbs', () => {});
+ xit('should show available dbs in dropdown', () => {});
+
+ // big query
+ xit('should be able to show custom big query', () => {});
+ xit('should be able to show big query file upload', () => {});
+ xit('should be able to show big query service account copy/paste', () => {});
xit('should keep create modal open when error', () => {
// open modal
[superset] 01/02: saving this for development
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/cypress-db-conn-ui
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 4c467f5decb1316ffcf03e5588f6095c1efdcf78
Author: hughhhh <hu...@gmail.com>
AuthorDate: Thu Jun 24 10:45:21 2021 -0700
saving this for development
---
superset-frontend/cypress-base/cypress/support/index.ts | 2 +-
.../views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx | 1 +
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx | 2 ++
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/cypress-base/cypress/support/index.ts b/superset-frontend/cypress-base/cypress/support/index.ts
index e22f699..639b6c9 100644
--- a/superset-frontend/cypress-base/cypress/support/index.ts
+++ b/superset-frontend/cypress-base/cypress/support/index.ts
@@ -35,7 +35,7 @@ Cypress.Commands.add('login', () => {
cy.request({
method: 'POST',
url: '/login/',
- body: { username: 'admin', password: 'general' },
+ body: { username: 'h', password: 'h' },
}).then(response => {
expect(response.status).to.eq(200);
});
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
index 5b9c57a..b79888c 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
@@ -335,6 +335,7 @@ const forceSSLField = ({
}: FieldPropTypes) => (
<div css={(theme: SupersetTheme) => infoTooltip(theme)}>
<Switch
+ name="encryption"
disabled={sslForced && !isEditMode}
checked={db?.parameters?.encryption || sslForced}
onChange={changed => {
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
index 9eae554..335e64a 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
@@ -598,6 +598,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
key="submit"
buttonStyle="primary"
onClick={onClose}
+ data-test="modal-confirm-button"
>
Finish
</StyledFooterButton>
@@ -997,6 +998,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
/>
<div css={(theme: SupersetTheme) => infoTooltip(theme)}>
<Button
+ data-test="sqla-connect-btn"
buttonStyle="link"
onClick={() =>
setDB({