You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/08/10 14:40:17 UTC
[GitHub] [solr] epugh opened a new pull request, #971: SOLR-11033: introduce multilingual configset
epugh opened a new pull request, #971:
URL: https://github.com/apache/solr/pull/971
https://issues.apache.org/jira/browse/SOLR-11033
# Description
See JIRA
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #971: SOLR-11033: introduce multilingual configset
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #971:
URL: https://github.com/apache/solr/pull/971#issuecomment-1215883911
The code for loading the `_multilingual` configset is rough, and probably can be refactored. However it all appears to work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #971: SOLR-11033: introduce multilingual configset
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #971:
URL: https://github.com/apache/solr/pull/971#issuecomment-1246667183
@thelabdude I just heard the very first rumbling of a 9.1 release.... Have you had a chance to think more about this approach? Does this need a discussion on the mailing list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-11033: introduce multilingual configset [solr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #971:
URL: https://github.com/apache/solr/pull/971#issuecomment-1951491351
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #971: SOLR-11033: introduce multilingual configset
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #971:
URL: https://github.com/apache/solr/pull/971#issuecomment-1216715124
TestSchemaDesignerConfigSetHelper.testEnableDisableOptions is busted... TestSchemaAPI all works.....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #971: SOLR-11033: introduce multilingual configset
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #971:
URL: https://github.com/apache/solr/pull/971#issuecomment-1218120819
Tests are now passing, though I don't love what I did in #7354bb629318a59ab51d80332f4cdf355d590cd7 to make it pass!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #971: SOLR-11033: introduce multilingual configset
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #971:
URL: https://github.com/apache/solr/pull/971#issuecomment-1216950625
Also, feel free to push any changes to this branch ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #971: SOLR-11033: introduce multilingual configset
Posted by GitBox <gi...@apache.org>.
epugh commented on PR #971:
URL: https://github.com/apache/solr/pull/971#issuecomment-1216981495
It actually isn't time sensitive... Though I hope it doesn't linger on the vine for weeks ;-). It would be nice to have it in before a 9.1 release. If this goes through, imagine if we added more sample collections like a `_geospatial` or `_embeddings` or even `_onnx` that users can adopt via the Schema Designer ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #971: SOLR-11033: introduce multilingual configset
Posted by GitBox <gi...@apache.org>.
thelabdude commented on PR #971:
URL: https://github.com/apache/solr/pull/971#issuecomment-1216977541
what's the timing for this? I see the jira was opened years ago, why is this needed now anyway?
I'll need some time (that I don't have right now) to think through all of this ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude commented on pull request #971: SOLR-11033: introduce multilingual configset
Posted by GitBox <gi...@apache.org>.
thelabdude commented on PR #971:
URL: https://github.com/apache/solr/pull/971#issuecomment-1215985472
Hi Eric, will go through this soon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org