You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/11/18 00:55:33 UTC
[GitHub] [geode] Kris-10-0 opened a new pull request #7123: GEODE-9816: Added CLIENT SETNAME and GETNAME commands.
Kris-10-0 opened a new pull request #7123:
URL: https://github.com/apache/geode/pull/7123
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [NA] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans merged pull request #7123: GEODE-9816: Added CLIENT SETNAME and GETNAME commands.
Posted by GitBox <gi...@apache.org>.
DonalEvans merged pull request #7123:
URL: https://github.com/apache/geode/pull/7123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7123: GEODE-9816: Added CLIENT SETNAME and GETNAME commands.
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #7123:
URL: https://github.com/apache/geode/pull/7123#discussion_r752329409
##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
##########
@@ -167,6 +168,7 @@
/*************** Connection ****************/
AUTH(new AuthExecutor(), SUPPORTED, new Parameter().min(2).max(3, ERROR_SYNTAX).firstKey(0)
.flags(NOSCRIPT, LOADING, STALE, FAST, NO_AUTH)),
+ CLIENT(new ClientExecutor(), SUPPORTED, new Parameter().min(2)),
Review comment:
It's easier to explain what this is about 'in person' than leave details here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7123: GEODE-9816: Added CLIENT SETNAME and GETNAME commands.
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #7123:
URL: https://github.com/apache/geode/pull/7123#discussion_r752322757
##########
File path: geode-log4j/src/main/resources/log4j2.xml
##########
@@ -32,6 +32,7 @@
</Appenders>
<Loggers>
<Logger name="com.gemstone" level="INFO" additivity="true"/>
+ <Logger name="org.testcontainers" level="DEBUG" additivity="true"/>
Review comment:
This should be removed
##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
##########
@@ -167,6 +168,7 @@
/*************** Connection ****************/
AUTH(new AuthExecutor(), SUPPORTED, new Parameter().min(2).max(3, ERROR_SYNTAX).firstKey(0)
.flags(NOSCRIPT, LOADING, STALE, FAST, NO_AUTH)),
+ CLIENT(new ClientExecutor(), SUPPORTED, new Parameter().min(2)),
Review comment:
You'll also need to add `.firstKey(0).flags(ADMIN, NOSCRIPT, RANDOM, LOADING, STALE)` in order to get `CommandIntegrationTest` to pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org