You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2022/04/01 09:43:21 UTC

[GitHub] [openwhisk-wskdebug] shazron edited a comment on pull request #96: fix: swap isomorphic-fetch for node-fetch for security issue

shazron edited a comment on pull request #96:
URL: https://github.com/apache/openwhisk-wskdebug/pull/96#issuecomment-1085447013


   @alexkli it's pretty clear now that there is a bug in the existing code, and nothing related to this PR. This line: https://github.com/apache/openwhisk-wskdebug/blob/1ec715d98136811bea30eb6a82b378d78e356252/src/agentmgr.js#L23 the result is always defined so this logic will always be false: https://github.com/apache/openwhisk-wskdebug/blob/1ec715d98136811bea30eb6a82b378d78e356252/src/agentmgr.js#L93 (if (true && !true) => if (false))
   
   There should be a `MODULE_NOT_FOUND` error thrown, but I'm not seeing it -- `npm ls ngrok` doesn't show anything either:
   ```
   ❯ npm ls ngrok
   @openwhisk/wskdebug@1.3.0 /Users/shazron/Documents/git/work/apache/openwhisk-wskdebug
   └── (empty)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org