[GitHub] [druid] FrankChen021 commented on a change in pull request #11878: Load cache files in parallel to speed up historical startup

[GitBox <gi...@apache.org>]

FrankChen021 commented on a change in pull request #11878:
URL: https://github.com/apache/druid/pull/11878#discussion_r743751178



##########
File path: server/src/main/java/org/apache/druid/segment/loading/SegmentLoaderConfig.java
##########
@@ -56,6 +56,9 @@
   @JsonProperty("numBootstrapThreads")
   private Integer numBootstrapThreads = null;
 
+  @JsonProperty("numCacheLoadThreads")
+  private int numCacheLoadThreads = 5;

Review comment:
       What is the purpose to make it a configuration item ? I think if we can make it default to the number of CPU cores? Or can we re-use `numBootstrapThreads` because it is defined as:
   > How many segments to load concurrently during historical startup.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org