[GitHub] JkSelf commented on a change in pull request #23204: Revert "[SPARK-21052][SQL] Add hash map metrics to join"

[GitBox <gi...@apache.org>]

JkSelf commented on a change in pull request #23204: Revert "[SPARK-21052][SQL] Add hash map metrics to join"
URL: https://github.com/apache/spark/pull/23204#discussion_r240460948
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
 ##########
 @@ -213,10 +213,6 @@ trait HashJoin {
           s"BroadcastHashJoin should not take $x as the JoinType")
     }
 
-    // At the end of the task, we update the avg hash probe.
-    TaskContext.get().addTaskCompletionListener[Unit](_ =>
 
 Review comment:
   @cloud-fan  updated in new PR [#23269](https://github.com/apache/spark/pull/23269) Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org